greybus: arche-platform: Add missing of_node_put() in arche_platform_change_state()

Wei Yongjun · gregkh · commit 25633d1f5dd7 · 2016-10-24T15:51:00.000+02:00
This node pointer is returned by of_find_compatible_node() with
refcount incremented in this function. of_node_put() on it before
exitting this function.

This is detected by Coccinelle semantic patch.

Signed-off-by: Wei Yongjun &lt;weiyongjun1@huawei.com&gt;
Acked-by: Johan Hovold &lt;johan@kernel.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
@@ -128,6 +128,7 @@ int arche_platform_change_state(enum arche_platform_state state,
 	pdev = of_find_device_by_node(np);
 	if (!pdev) {
 		pr_err("arche-platform device not found\n");
+		of_node_put(np);
 		return -ENODEV;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -128,6 +128,7 @@ int arche_platform_change_state(enum arche_platform_state state,`
`128`	`128`	`pdev = of_find_device_by_node(np);`
`129`	`129`	`if (!pdev) {`
`130`	`130`	`pr_err("arche-platform device not found\n");`
	`131`	`+ of_node_put(np);`
`131`	`132`	`return -ENODEV;`
`132`	`133`	`}`
`133`	`134`