Skip to content

Commit 265b07d

Browse files
shradhatbebarino
authored andcommitted
clk: Provide managed helper to get and enable bulk clocks
Provide a managed devm_clk_bulk* wrapper to get and enable all bulk clocks in order to simplify drivers that keeps all clocks enabled for the time of driver operation. Suggested-by: Marek Szyprowski <[email protected]> Reviewed-by: Alim Akhtar <[email protected]> Reviewed-by: Manivannan Sadhasivam <[email protected]> Signed-off-by: Shradha Todi <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Stephen Boyd <[email protected]>
1 parent 6613476 commit 265b07d

File tree

2 files changed

+62
-0
lines changed

2 files changed

+62
-0
lines changed

drivers/clk/clk-devres.c

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,46 @@ int __must_check devm_clk_bulk_get_all(struct device *dev,
182182
}
183183
EXPORT_SYMBOL_GPL(devm_clk_bulk_get_all);
184184

185+
static void devm_clk_bulk_release_all_enable(struct device *dev, void *res)
186+
{
187+
struct clk_bulk_devres *devres = res;
188+
189+
clk_bulk_disable_unprepare(devres->num_clks, devres->clks);
190+
clk_bulk_put_all(devres->num_clks, devres->clks);
191+
}
192+
193+
int __must_check devm_clk_bulk_get_all_enable(struct device *dev,
194+
struct clk_bulk_data **clks)
195+
{
196+
struct clk_bulk_devres *devres;
197+
int ret;
198+
199+
devres = devres_alloc(devm_clk_bulk_release_all_enable,
200+
sizeof(*devres), GFP_KERNEL);
201+
if (!devres)
202+
return -ENOMEM;
203+
204+
ret = clk_bulk_get_all(dev, &devres->clks);
205+
if (ret > 0) {
206+
*clks = devres->clks;
207+
devres->num_clks = ret;
208+
} else {
209+
devres_free(devres);
210+
return ret;
211+
}
212+
213+
ret = clk_bulk_prepare_enable(devres->num_clks, *clks);
214+
if (!ret) {
215+
devres_add(dev, devres);
216+
} else {
217+
clk_bulk_put_all(devres->num_clks, devres->clks);
218+
devres_free(devres);
219+
}
220+
221+
return ret;
222+
}
223+
EXPORT_SYMBOL_GPL(devm_clk_bulk_get_all_enable);
224+
185225
static int devm_clk_match(struct device *dev, void *res, void *data)
186226
{
187227
struct clk **c = res;

include/linux/clk.h

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -478,6 +478,22 @@ int __must_check devm_clk_bulk_get_optional(struct device *dev, int num_clks,
478478
int __must_check devm_clk_bulk_get_all(struct device *dev,
479479
struct clk_bulk_data **clks);
480480

481+
/**
482+
* devm_clk_bulk_get_all_enable - Get and enable all clocks of the consumer (managed)
483+
* @dev: device for clock "consumer"
484+
* @clks: pointer to the clk_bulk_data table of consumer
485+
*
486+
* Returns success (0) or negative errno.
487+
*
488+
* This helper function allows drivers to get all clocks of the
489+
* consumer and enables them in one operation with management.
490+
* The clks will automatically be disabled and freed when the device
491+
* is unbound.
492+
*/
493+
494+
int __must_check devm_clk_bulk_get_all_enable(struct device *dev,
495+
struct clk_bulk_data **clks);
496+
481497
/**
482498
* devm_clk_get - lookup and obtain a managed reference to a clock producer.
483499
* @dev: device for clock "consumer"
@@ -968,6 +984,12 @@ static inline int __must_check devm_clk_bulk_get_all(struct device *dev,
968984
return 0;
969985
}
970986

987+
static inline int __must_check devm_clk_bulk_get_all_enable(struct device *dev,
988+
struct clk_bulk_data **clks)
989+
{
990+
return 0;
991+
}
992+
971993
static inline struct clk *devm_get_clk_from_child(struct device *dev,
972994
struct device_node *np, const char *con_id)
973995
{

0 commit comments

Comments
 (0)