net: lantiq: fix missing free_netdev() on error in ltq_etop_probe()

Yang Yingliang · davem330 · commit 2680ce7fc993 · 2021-11-30T12:11:27.000Z
Add the missing free_netdev() before return from ltq_etop_probe() in the error handling case. Fixes: 14d4e30 ("net: lantiq: configure the burst length in ethernet drivers") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
@@ -687,13 +687,13 @@ ltq_etop_probe(struct platform_device *pdev)
 	err = device_property_read_u32(&pdev->dev, "lantiq,tx-burst-length", &priv->tx_burst_len);
 	if (err < 0) {
 		dev_err(&pdev->dev, "unable to read tx-burst-length property\n");
-		return err;
+		goto err_free;
 	}
 
 	err = device_property_read_u32(&pdev->dev, "lantiq,rx-burst-length", &priv->rx_burst_len);
 	if (err < 0) {
 		dev_err(&pdev->dev, "unable to read rx-burst-length property\n");
-		return err;
+		goto err_free;
 	}
 
 	for (i = 0; i < MAX_DMA_CHAN; i++) {

Original file line number	Diff line number	Diff line change
`@@ -687,13 +687,13 @@ ltq_etop_probe(struct platform_device *pdev)`
`687`	`687`	`err = device_property_read_u32(&pdev->dev, "lantiq,tx-burst-length", &priv->tx_burst_len);`
`688`	`688`	`if (err < 0) {`
`689`	`689`	`dev_err(&pdev->dev, "unable to read tx-burst-length property\n");`
`690`		`- return err;`
	`690`	`+ goto err_free;`
`691`	`691`	`}`
`692`	`692`
`693`	`693`	`err = device_property_read_u32(&pdev->dev, "lantiq,rx-burst-length", &priv->rx_burst_len);`
`694`	`694`	`if (err < 0) {`
`695`	`695`	`dev_err(&pdev->dev, "unable to read rx-burst-length property\n");`
`696`		`- return err;`
	`696`	`+ goto err_free;`
`697`	`697`	`}`
`698`	`698`
`699`	`699`	`for (i = 0; i < MAX_DMA_CHAN; i++) {`