Skip to content

Commit 26de0b7

Browse files
Finn Thaindavem330
authored andcommitted
net/sonic: Use dma_mapping_error()
With CONFIG_DMA_API_DEBUG=y, calling sonic_open() produces the message, "DMA-API: device driver failed to check map error". Add the missing dma_mapping_error() call. Cc: Thomas Bogendoerfer <[email protected]> Signed-off-by: Finn Thain <[email protected]> Acked-by: Thomas Bogendoerfer <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent f5a4941 commit 26de0b7

File tree

1 file changed

+1
-1
lines changed
  • drivers/net/ethernet/natsemi

1 file changed

+1
-1
lines changed

drivers/net/ethernet/natsemi/sonic.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ static int sonic_open(struct net_device *dev)
8484
for (i = 0; i < SONIC_NUM_RRS; i++) {
8585
dma_addr_t laddr = dma_map_single(lp->device, skb_put(lp->rx_skb[i], SONIC_RBSIZE),
8686
SONIC_RBSIZE, DMA_FROM_DEVICE);
87-
if (!laddr) {
87+
if (dma_mapping_error(lp->device, laddr)) {
8888
while(i > 0) { /* free any that were mapped successfully */
8989
i--;
9090
dma_unmap_single(lp->device, lp->rx_laddr[i], SONIC_RBSIZE, DMA_FROM_DEVICE);

0 commit comments

Comments
 (0)