Skip to content

Commit 2862eee

Browse files
Yang Erkunchucklever
authored andcommitted
SUNRPC: make sure cache entry active before cache_show
The function `c_show` was called with protection from RCU. This only ensures that `cp` will not be freed. Therefore, the reference count for `cp` can drop to zero, which will trigger a refcount use-after-free warning when `cache_get` is called. To resolve this issue, use `cache_get_rcu` to ensure that `cp` remains active. ------------[ cut here ]------------ refcount_t: addition on 0; use-after-free. WARNING: CPU: 7 PID: 822 at lib/refcount.c:25 refcount_warn_saturate+0xb1/0x120 CPU: 7 UID: 0 PID: 822 Comm: cat Not tainted 6.12.0-rc3+ #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.1-2.fc37 04/01/2014 RIP: 0010:refcount_warn_saturate+0xb1/0x120 Call Trace: <TASK> c_show+0x2fc/0x380 [sunrpc] seq_read_iter+0x589/0x770 seq_read+0x1e5/0x270 proc_reg_read+0xe1/0x140 vfs_read+0x125/0x530 ksys_read+0xc1/0x160 do_syscall_64+0x5f/0x170 entry_SYSCALL_64_after_hwframe+0x76/0x7e Cc: [email protected] # v4.20+ Signed-off-by: Yang Erkun <[email protected]> Reviewed-by: Jeff Layton <[email protected]> Signed-off-by: Chuck Lever <[email protected]>
1 parent be8f982 commit 2862eee

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

net/sunrpc/cache.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1427,7 +1427,9 @@ static int c_show(struct seq_file *m, void *p)
14271427
seq_printf(m, "# expiry=%lld refcnt=%d flags=%lx\n",
14281428
convert_to_wallclock(cp->expiry_time),
14291429
kref_read(&cp->ref), cp->flags);
1430-
cache_get(cp);
1430+
if (!cache_get_rcu(cp))
1431+
return 0;
1432+
14311433
if (cache_check(cd, cp, NULL))
14321434
/* cache_check does a cache_put on failure */
14331435
seq_puts(m, "# ");

0 commit comments

Comments
 (0)