Skip to content

Commit 2b064ff

Browse files
rnavdavem330
authored andcommitted
bpf samples: fix compiler errors with sockex2 and sockex3
These samples fail to compile as 'struct flow_keys' conflicts with definition in net/flow_dissector.h. Fix the same by renaming the structure used in the sample. Signed-off-by: Naveen N. Rao <[email protected]> Acked-by: Alexei Starovoitov <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent b6f5be2 commit 2b064ff

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

samples/bpf/sockex2_kern.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ struct vlan_hdr {
1414
__be16 h_vlan_encapsulated_proto;
1515
};
1616

17-
struct flow_keys {
17+
struct bpf_flow_keys {
1818
__be32 src;
1919
__be32 dst;
2020
union {
@@ -59,7 +59,7 @@ static inline __u32 ipv6_addr_hash(struct __sk_buff *ctx, __u64 off)
5959
}
6060

6161
static inline __u64 parse_ip(struct __sk_buff *skb, __u64 nhoff, __u64 *ip_proto,
62-
struct flow_keys *flow)
62+
struct bpf_flow_keys *flow)
6363
{
6464
__u64 verlen;
6565

@@ -83,7 +83,7 @@ static inline __u64 parse_ip(struct __sk_buff *skb, __u64 nhoff, __u64 *ip_proto
8383
}
8484

8585
static inline __u64 parse_ipv6(struct __sk_buff *skb, __u64 nhoff, __u64 *ip_proto,
86-
struct flow_keys *flow)
86+
struct bpf_flow_keys *flow)
8787
{
8888
*ip_proto = load_byte(skb,
8989
nhoff + offsetof(struct ipv6hdr, nexthdr));
@@ -96,7 +96,7 @@ static inline __u64 parse_ipv6(struct __sk_buff *skb, __u64 nhoff, __u64 *ip_pro
9696
return nhoff;
9797
}
9898

99-
static inline bool flow_dissector(struct __sk_buff *skb, struct flow_keys *flow)
99+
static inline bool flow_dissector(struct __sk_buff *skb, struct bpf_flow_keys *flow)
100100
{
101101
__u64 nhoff = ETH_HLEN;
102102
__u64 ip_proto;
@@ -198,7 +198,7 @@ struct bpf_map_def SEC("maps") hash_map = {
198198
SEC("socket2")
199199
int bpf_prog2(struct __sk_buff *skb)
200200
{
201-
struct flow_keys flow;
201+
struct bpf_flow_keys flow;
202202
struct pair *value;
203203
u32 key;
204204

samples/bpf/sockex3_kern.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ struct vlan_hdr {
6161
__be16 h_vlan_encapsulated_proto;
6262
};
6363

64-
struct flow_keys {
64+
struct bpf_flow_keys {
6565
__be32 src;
6666
__be32 dst;
6767
union {
@@ -88,7 +88,7 @@ static inline __u32 ipv6_addr_hash(struct __sk_buff *ctx, __u64 off)
8888
}
8989

9090
struct globals {
91-
struct flow_keys flow;
91+
struct bpf_flow_keys flow;
9292
};
9393

9494
struct bpf_map_def SEC("maps") percpu_map = {
@@ -114,14 +114,14 @@ struct pair {
114114

115115
struct bpf_map_def SEC("maps") hash_map = {
116116
.type = BPF_MAP_TYPE_HASH,
117-
.key_size = sizeof(struct flow_keys),
117+
.key_size = sizeof(struct bpf_flow_keys),
118118
.value_size = sizeof(struct pair),
119119
.max_entries = 1024,
120120
};
121121

122122
static void update_stats(struct __sk_buff *skb, struct globals *g)
123123
{
124-
struct flow_keys key = g->flow;
124+
struct bpf_flow_keys key = g->flow;
125125
struct pair *value;
126126

127127
value = bpf_map_lookup_elem(&hash_map, &key);

samples/bpf/sockex3_user.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#include <arpa/inet.h>
88
#include <sys/resource.h>
99

10-
struct flow_keys {
10+
struct bpf_flow_keys {
1111
__be32 src;
1212
__be32 dst;
1313
union {
@@ -49,7 +49,7 @@ int main(int argc, char **argv)
4949
(void) f;
5050

5151
for (i = 0; i < 5; i++) {
52-
struct flow_keys key = {}, next_key;
52+
struct bpf_flow_keys key = {}, next_key;
5353
struct pair value;
5454

5555
sleep(1);

0 commit comments

Comments
 (0)