Skip to content

Commit 2b239e7

Browse files
jpirkodavem330
authored andcommitted
net: devlink: warn on setting type on unregistered port
Port needs to be registered first before the type is set. Warn and bail-out in case it is not. Signed-off-by: Jiri Pirko <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent d0d54e8 commit 2b239e7

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

net/core/devlink.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5328,6 +5328,8 @@ static void __devlink_port_type_set(struct devlink_port *devlink_port,
53285328
enum devlink_port_type type,
53295329
void *type_dev)
53305330
{
5331+
if (WARN_ON(!devlink_port->registered))
5332+
return;
53315333
devlink_port->type = type;
53325334
devlink_port->type_dev = type_dev;
53335335
devlink_port_notify(devlink_port, DEVLINK_CMD_PORT_NEW);

0 commit comments

Comments
 (0)