Skip to content

Commit 2c08740

Browse files
Philippe Reynesdavem330
authored andcommitted
net: ethernet: smsc: smsc911x: use phy_ethtool_{get|set}_link_ksettings
There are two generics functions phy_ethtool_{get|set}_link_ksettings, so we can use them instead of defining the same code in the driver. Signed-off-by: Philippe Reynes <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent f788e32 commit 2c08740

File tree

1 file changed

+2
-16
lines changed

1 file changed

+2
-16
lines changed

drivers/net/ethernet/smsc/smsc911x.c

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1915,20 +1915,6 @@ static int smsc911x_do_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
19151915
return phy_mii_ioctl(dev->phydev, ifr, cmd);
19161916
}
19171917

1918-
static int
1919-
smsc911x_ethtool_getsettings(struct net_device *dev, struct ethtool_cmd *cmd)
1920-
{
1921-
cmd->maxtxpkt = 1;
1922-
cmd->maxrxpkt = 1;
1923-
return phy_ethtool_gset(dev->phydev, cmd);
1924-
}
1925-
1926-
static int
1927-
smsc911x_ethtool_setsettings(struct net_device *dev, struct ethtool_cmd *cmd)
1928-
{
1929-
return phy_ethtool_sset(dev->phydev, cmd);
1930-
}
1931-
19321918
static void smsc911x_ethtool_getdrvinfo(struct net_device *dev,
19331919
struct ethtool_drvinfo *info)
19341920
{
@@ -2112,8 +2098,6 @@ static int smsc911x_ethtool_set_eeprom(struct net_device *dev,
21122098
}
21132099

21142100
static const struct ethtool_ops smsc911x_ethtool_ops = {
2115-
.get_settings = smsc911x_ethtool_getsettings,
2116-
.set_settings = smsc911x_ethtool_setsettings,
21172101
.get_link = ethtool_op_get_link,
21182102
.get_drvinfo = smsc911x_ethtool_getdrvinfo,
21192103
.nway_reset = smsc911x_ethtool_nwayreset,
@@ -2125,6 +2109,8 @@ static const struct ethtool_ops smsc911x_ethtool_ops = {
21252109
.get_eeprom = smsc911x_ethtool_get_eeprom,
21262110
.set_eeprom = smsc911x_ethtool_set_eeprom,
21272111
.get_ts_info = ethtool_op_get_ts_info,
2112+
.get_link_ksettings = phy_ethtool_get_link_ksettings,
2113+
.set_link_ksettings = phy_ethtool_set_link_ksettings,
21282114
};
21292115

21302116
static const struct net_device_ops smsc911x_netdev_ops = {

0 commit comments

Comments
 (0)