Skip to content

Commit 2c9c168

Browse files
Ursula Braundavem330
authored andcommitted
net/smc: do not use IB_SEND_INLINE together with mapped data
smc specifies IB_SEND_INLINE for IB_WR_SEND ib_post_send calls, but provides a mapped buffer to be sent. This is inconsistent, since IB_SEND_INLINE works without mapped buffer. Problem has not been detected in the past, because tests had been limited to Connect X3 cards from Mellanox, whose mlx4 driver just ignored the IB_SEND_INLINE flag. For now, the IB_SEND_INLINE flag is removed. Signed-off-by: Ursula Braun <[email protected]> Reviewed-by: Thomas Richter <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 288c839 commit 2c9c168

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

net/smc/smc_ib.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,6 @@ int smc_ib_create_queue_pair(struct smc_link *lnk)
257257
.max_recv_wr = SMC_WR_BUF_CNT * 3,
258258
.max_send_sge = SMC_IB_MAX_SEND_SGE,
259259
.max_recv_sge = 1,
260-
.max_inline_data = SMC_WR_TX_SIZE,
261260
},
262261
.sq_sig_type = IB_SIGNAL_REQ_WR,
263262
.qp_type = IB_QPT_RC,

net/smc/smc_wr.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -447,7 +447,7 @@ static void smc_wr_init_sge(struct smc_link *lnk)
447447
lnk->wr_tx_ibs[i].num_sge = 1;
448448
lnk->wr_tx_ibs[i].opcode = IB_WR_SEND;
449449
lnk->wr_tx_ibs[i].send_flags =
450-
IB_SEND_SIGNALED | IB_SEND_SOLICITED | IB_SEND_INLINE;
450+
IB_SEND_SIGNALED | IB_SEND_SOLICITED;
451451
}
452452
for (i = 0; i < lnk->wr_rx_cnt; i++) {
453453
lnk->wr_rx_sges[i].addr =

0 commit comments

Comments
 (0)