Skip to content

Commit 2ce0af8

Browse files
committed
Merge branch 'qed-fixes'
Yuval Mintz says: ==================== qed: Fix RoCE infrastructure This series fixes 2 basic issues with RoCE support, one handles a missing configuration in the initial infrastructure support while the other is a regression introduced by one of the initial fix submissions. ==================== Signed-off-by: David S. Miller <[email protected]>
2 parents 0ace81e + 5c5f260 commit 2ce0af8

File tree

3 files changed

+9
-12
lines changed

3 files changed

+9
-12
lines changed

drivers/net/ethernet/qlogic/qed/qed_hsi.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -727,9 +727,6 @@ struct core_tx_bd_flags {
727727
#define CORE_TX_BD_FLAGS_L4_PROTOCOL_SHIFT 6
728728
#define CORE_TX_BD_FLAGS_L4_PSEUDO_CSUM_MODE_MASK 0x1
729729
#define CORE_TX_BD_FLAGS_L4_PSEUDO_CSUM_MODE_SHIFT 7
730-
#define CORE_TX_BD_FLAGS_ROCE_FLAV_MASK 0x1
731-
#define CORE_TX_BD_FLAGS_ROCE_FLAV_SHIFT 12
732-
733730
};
734731

735732
struct core_tx_bd {

drivers/net/ethernet/qlogic/qed/qed_ll2.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1119,6 +1119,7 @@ static void qed_ll2_prepare_tx_packet_set_bd(struct qed_hwfn *p_hwfn,
11191119
start_bd->bd_flags.as_bitfield |= CORE_TX_BD_FLAGS_START_BD_MASK <<
11201120
CORE_TX_BD_FLAGS_START_BD_SHIFT;
11211121
SET_FIELD(start_bd->bitfield0, CORE_TX_BD_NBDS, num_of_bds);
1122+
SET_FIELD(start_bd->bitfield0, CORE_TX_BD_ROCE_FLAV, type);
11221123
DMA_REGPAIR_LE(start_bd->addr, first_frag);
11231124
start_bd->nbytes = cpu_to_le16(first_frag_len);
11241125

drivers/net/ethernet/qlogic/qed/qed_main.c

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -839,20 +839,19 @@ static void qed_update_pf_params(struct qed_dev *cdev,
839839
{
840840
int i;
841841

842+
if (IS_ENABLED(CONFIG_QED_RDMA)) {
843+
params->rdma_pf_params.num_qps = QED_ROCE_QPS;
844+
params->rdma_pf_params.min_dpis = QED_ROCE_DPIS;
845+
/* divide by 3 the MRs to avoid MF ILT overflow */
846+
params->rdma_pf_params.num_mrs = RDMA_MAX_TIDS;
847+
params->rdma_pf_params.gl_pi = QED_ROCE_PROTOCOL_INDEX;
848+
}
849+
842850
for (i = 0; i < cdev->num_hwfns; i++) {
843851
struct qed_hwfn *p_hwfn = &cdev->hwfns[i];
844852

845853
p_hwfn->pf_params = *params;
846854
}
847-
848-
if (!IS_ENABLED(CONFIG_QED_RDMA))
849-
return;
850-
851-
params->rdma_pf_params.num_qps = QED_ROCE_QPS;
852-
params->rdma_pf_params.min_dpis = QED_ROCE_DPIS;
853-
/* divide by 3 the MRs to avoid MF ILT overflow */
854-
params->rdma_pf_params.num_mrs = RDMA_MAX_TIDS;
855-
params->rdma_pf_params.gl_pi = QED_ROCE_PROTOCOL_INDEX;
856855
}
857856

858857
static int qed_slowpath_start(struct qed_dev *cdev,

0 commit comments

Comments
 (0)