Skip to content

Commit 2d12a18

Browse files
committed
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/sameo/mfd-2.6
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/sameo/mfd-2.6: mfd: Add Makefile and Kconfig Entries for tps65911 comparator mfd: Fix build error for tps65911-comparator.c Revert "mfd: Add omap-usbhs runtime PM support" input: pmic8xxx-pwrkey: Do not use mfd_get_data() input: pmic8xxx-keypad: Do not use mfd_get_data()
2 parents 121782a + 8509e14 commit 2d12a18

File tree

6 files changed

+131
-12
lines changed

6 files changed

+131
-12
lines changed

drivers/input/keyboard/pmic8xxx-keypad.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,8 @@ static void pmic8xxx_kp_close(struct input_dev *dev)
520520
*/
521521
static int __devinit pmic8xxx_kp_probe(struct platform_device *pdev)
522522
{
523-
const struct pm8xxx_keypad_platform_data *pdata = mfd_get_data(pdev);
523+
const struct pm8xxx_keypad_platform_data *pdata =
524+
dev_get_platdata(&pdev->dev);
524525
const struct matrix_keymap_data *keymap_data;
525526
struct pmic8xxx_kp *kp;
526527
int rc;

drivers/input/misc/pmic8xxx-pwrkey.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,8 @@ static int __devinit pmic8xxx_pwrkey_probe(struct platform_device *pdev)
9090
unsigned int delay;
9191
u8 pon_cntl;
9292
struct pmic8xxx_pwrkey *pwrkey;
93-
const struct pm8xxx_pwrkey_platform_data *pdata = mfd_get_data(pdev);
93+
const struct pm8xxx_pwrkey_platform_data *pdata =
94+
dev_get_platdata(&pdev->dev);
9495

9596
if (!pdata) {
9697
dev_err(&pdev->dev, "power key platform data not supplied\n");

drivers/mfd/Kconfig

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -728,6 +728,9 @@ config MFD_TPS65910
728728
if you say yes here you get support for the TPS65910 series of
729729
Power Management chips.
730730

731+
config TPS65911_COMPARATOR
732+
tristate
733+
731734
endif # MFD_SUPPORT
732735

733736
menu "Multimedia Capabilities Port drivers"

drivers/mfd/Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,3 +94,4 @@ obj-$(CONFIG_MFD_OMAP_USB_HOST) += omap-usb-host.o
9494
obj-$(CONFIG_MFD_PM8921_CORE) += pm8921-core.o
9595
obj-$(CONFIG_MFD_PM8XXX_IRQ) += pm8xxx-irq.o
9696
obj-$(CONFIG_MFD_TPS65910) += tps65910.o tps65910-irq.o
97+
obj-$(CONFIG_TPS65911_COMPARATOR) += tps65911-comparator.o

drivers/mfd/omap-usb-host.c

Lines changed: 122 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
#include <linux/spinlock.h>
2727
#include <linux/gpio.h>
2828
#include <plat/usb.h>
29-
#include <linux/pm_runtime.h>
3029

3130
#define USBHS_DRIVER_NAME "usbhs-omap"
3231
#define OMAP_EHCI_DEVICE "ehci-omap"
@@ -147,6 +146,9 @@
147146

148147

149148
struct usbhs_hcd_omap {
149+
struct clk *usbhost_ick;
150+
struct clk *usbhost_hs_fck;
151+
struct clk *usbhost_fs_fck;
150152
struct clk *xclk60mhsp1_ck;
151153
struct clk *xclk60mhsp2_ck;
152154
struct clk *utmi_p1_fck;
@@ -156,6 +158,8 @@ struct usbhs_hcd_omap {
156158
struct clk *usbhost_p2_fck;
157159
struct clk *usbtll_p2_fck;
158160
struct clk *init_60m_fclk;
161+
struct clk *usbtll_fck;
162+
struct clk *usbtll_ick;
159163

160164
void __iomem *uhh_base;
161165
void __iomem *tll_base;
@@ -349,13 +353,46 @@ static int __devinit usbhs_omap_probe(struct platform_device *pdev)
349353
omap->platdata.ehci_data = pdata->ehci_data;
350354
omap->platdata.ohci_data = pdata->ohci_data;
351355

352-
pm_runtime_enable(&pdev->dev);
356+
omap->usbhost_ick = clk_get(dev, "usbhost_ick");
357+
if (IS_ERR(omap->usbhost_ick)) {
358+
ret = PTR_ERR(omap->usbhost_ick);
359+
dev_err(dev, "usbhost_ick failed error:%d\n", ret);
360+
goto err_end;
361+
}
362+
363+
omap->usbhost_hs_fck = clk_get(dev, "hs_fck");
364+
if (IS_ERR(omap->usbhost_hs_fck)) {
365+
ret = PTR_ERR(omap->usbhost_hs_fck);
366+
dev_err(dev, "usbhost_hs_fck failed error:%d\n", ret);
367+
goto err_usbhost_ick;
368+
}
369+
370+
omap->usbhost_fs_fck = clk_get(dev, "fs_fck");
371+
if (IS_ERR(omap->usbhost_fs_fck)) {
372+
ret = PTR_ERR(omap->usbhost_fs_fck);
373+
dev_err(dev, "usbhost_fs_fck failed error:%d\n", ret);
374+
goto err_usbhost_hs_fck;
375+
}
376+
377+
omap->usbtll_fck = clk_get(dev, "usbtll_fck");
378+
if (IS_ERR(omap->usbtll_fck)) {
379+
ret = PTR_ERR(omap->usbtll_fck);
380+
dev_err(dev, "usbtll_fck failed error:%d\n", ret);
381+
goto err_usbhost_fs_fck;
382+
}
383+
384+
omap->usbtll_ick = clk_get(dev, "usbtll_ick");
385+
if (IS_ERR(omap->usbtll_ick)) {
386+
ret = PTR_ERR(omap->usbtll_ick);
387+
dev_err(dev, "usbtll_ick failed error:%d\n", ret);
388+
goto err_usbtll_fck;
389+
}
353390

354391
omap->utmi_p1_fck = clk_get(dev, "utmi_p1_gfclk");
355392
if (IS_ERR(omap->utmi_p1_fck)) {
356393
ret = PTR_ERR(omap->utmi_p1_fck);
357394
dev_err(dev, "utmi_p1_gfclk failed error:%d\n", ret);
358-
goto err_end;
395+
goto err_usbtll_ick;
359396
}
360397

361398
omap->xclk60mhsp1_ck = clk_get(dev, "xclk60mhsp1_ck");
@@ -485,8 +522,22 @@ static int __devinit usbhs_omap_probe(struct platform_device *pdev)
485522
err_utmi_p1_fck:
486523
clk_put(omap->utmi_p1_fck);
487524

525+
err_usbtll_ick:
526+
clk_put(omap->usbtll_ick);
527+
528+
err_usbtll_fck:
529+
clk_put(omap->usbtll_fck);
530+
531+
err_usbhost_fs_fck:
532+
clk_put(omap->usbhost_fs_fck);
533+
534+
err_usbhost_hs_fck:
535+
clk_put(omap->usbhost_hs_fck);
536+
537+
err_usbhost_ick:
538+
clk_put(omap->usbhost_ick);
539+
488540
err_end:
489-
pm_runtime_disable(&pdev->dev);
490541
kfree(omap);
491542

492543
end_probe:
@@ -520,7 +571,11 @@ static int __devexit usbhs_omap_remove(struct platform_device *pdev)
520571
clk_put(omap->utmi_p2_fck);
521572
clk_put(omap->xclk60mhsp1_ck);
522573
clk_put(omap->utmi_p1_fck);
523-
pm_runtime_disable(&pdev->dev);
574+
clk_put(omap->usbtll_ick);
575+
clk_put(omap->usbtll_fck);
576+
clk_put(omap->usbhost_fs_fck);
577+
clk_put(omap->usbhost_hs_fck);
578+
clk_put(omap->usbhost_ick);
524579
kfree(omap);
525580

526581
return 0;
@@ -640,6 +695,7 @@ static int usbhs_enable(struct device *dev)
640695
struct usbhs_omap_platform_data *pdata = &omap->platdata;
641696
unsigned long flags = 0;
642697
int ret = 0;
698+
unsigned long timeout;
643699
unsigned reg;
644700

645701
dev_dbg(dev, "starting TI HSUSB Controller\n");
@@ -652,7 +708,11 @@ static int usbhs_enable(struct device *dev)
652708
if (omap->count > 0)
653709
goto end_count;
654710

655-
pm_runtime_get_sync(dev);
711+
clk_enable(omap->usbhost_ick);
712+
clk_enable(omap->usbhost_hs_fck);
713+
clk_enable(omap->usbhost_fs_fck);
714+
clk_enable(omap->usbtll_fck);
715+
clk_enable(omap->usbtll_ick);
656716

657717
if (pdata->ehci_data->phy_reset) {
658718
if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[0])) {
@@ -676,6 +736,50 @@ static int usbhs_enable(struct device *dev)
676736
omap->usbhs_rev = usbhs_read(omap->uhh_base, OMAP_UHH_REVISION);
677737
dev_dbg(dev, "OMAP UHH_REVISION 0x%x\n", omap->usbhs_rev);
678738

739+
/* perform TLL soft reset, and wait until reset is complete */
740+
usbhs_write(omap->tll_base, OMAP_USBTLL_SYSCONFIG,
741+
OMAP_USBTLL_SYSCONFIG_SOFTRESET);
742+
743+
/* Wait for TLL reset to complete */
744+
timeout = jiffies + msecs_to_jiffies(1000);
745+
while (!(usbhs_read(omap->tll_base, OMAP_USBTLL_SYSSTATUS)
746+
& OMAP_USBTLL_SYSSTATUS_RESETDONE)) {
747+
cpu_relax();
748+
749+
if (time_after(jiffies, timeout)) {
750+
dev_dbg(dev, "operation timed out\n");
751+
ret = -EINVAL;
752+
goto err_tll;
753+
}
754+
}
755+
756+
dev_dbg(dev, "TLL RESET DONE\n");
757+
758+
/* (1<<3) = no idle mode only for initial debugging */
759+
usbhs_write(omap->tll_base, OMAP_USBTLL_SYSCONFIG,
760+
OMAP_USBTLL_SYSCONFIG_ENAWAKEUP |
761+
OMAP_USBTLL_SYSCONFIG_SIDLEMODE |
762+
OMAP_USBTLL_SYSCONFIG_AUTOIDLE);
763+
764+
/* Put UHH in NoIdle/NoStandby mode */
765+
reg = usbhs_read(omap->uhh_base, OMAP_UHH_SYSCONFIG);
766+
if (is_omap_usbhs_rev1(omap)) {
767+
reg |= (OMAP_UHH_SYSCONFIG_ENAWAKEUP
768+
| OMAP_UHH_SYSCONFIG_SIDLEMODE
769+
| OMAP_UHH_SYSCONFIG_CACTIVITY
770+
| OMAP_UHH_SYSCONFIG_MIDLEMODE);
771+
reg &= ~OMAP_UHH_SYSCONFIG_AUTOIDLE;
772+
773+
774+
} else if (is_omap_usbhs_rev2(omap)) {
775+
reg &= ~OMAP4_UHH_SYSCONFIG_IDLEMODE_CLEAR;
776+
reg |= OMAP4_UHH_SYSCONFIG_NOIDLE;
777+
reg &= ~OMAP4_UHH_SYSCONFIG_STDBYMODE_CLEAR;
778+
reg |= OMAP4_UHH_SYSCONFIG_NOSTDBY;
779+
}
780+
781+
usbhs_write(omap->uhh_base, OMAP_UHH_SYSCONFIG, reg);
782+
679783
reg = usbhs_read(omap->uhh_base, OMAP_UHH_HOSTCONFIG);
680784
/* setup ULPI bypass and burst configurations */
681785
reg |= (OMAP_UHH_HOSTCONFIG_INCR4_BURST_EN
@@ -815,15 +919,20 @@ static int usbhs_enable(struct device *dev)
815919
return 0;
816920

817921
err_tll:
818-
pm_runtime_put_sync(dev);
819-
spin_unlock_irqrestore(&omap->lock, flags);
820922
if (pdata->ehci_data->phy_reset) {
821923
if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[0]))
822924
gpio_free(pdata->ehci_data->reset_gpio_port[0]);
823925

824926
if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[1]))
825927
gpio_free(pdata->ehci_data->reset_gpio_port[1]);
826928
}
929+
930+
clk_disable(omap->usbtll_ick);
931+
clk_disable(omap->usbtll_fck);
932+
clk_disable(omap->usbhost_fs_fck);
933+
clk_disable(omap->usbhost_hs_fck);
934+
clk_disable(omap->usbhost_ick);
935+
spin_unlock_irqrestore(&omap->lock, flags);
827936
return ret;
828937
}
829938

@@ -896,7 +1005,11 @@ static void usbhs_disable(struct device *dev)
8961005
clk_disable(omap->utmi_p1_fck);
8971006
}
8981007

899-
pm_runtime_put_sync(dev);
1008+
clk_disable(omap->usbtll_ick);
1009+
clk_disable(omap->usbtll_fck);
1010+
clk_disable(omap->usbhost_fs_fck);
1011+
clk_disable(omap->usbhost_hs_fck);
1012+
clk_disable(omap->usbhost_ick);
9001013

9011014
/* The gpio_free migh sleep; so unlock the spinlock */
9021015
spin_unlock_irqrestore(&omap->lock, flags);

drivers/mfd/tps65911-comparator.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ static DEVICE_ATTR(comp2_threshold, S_IRUGO, comp_threshold_show, NULL);
125125
static __devinit int tps65911_comparator_probe(struct platform_device *pdev)
126126
{
127127
struct tps65910 *tps65910 = dev_get_drvdata(pdev->dev.parent);
128-
struct tps65910_platform_data *pdata = dev_get_platdata(tps65910->dev);
128+
struct tps65910_board *pdata = dev_get_platdata(tps65910->dev);
129129
int ret;
130130

131131
ret = comp_threshold_set(tps65910, COMP1, pdata->vmbch_threshold);

0 commit comments

Comments
 (0)