Skip to content

Commit 2eaac32

Browse files
tititiou36axboe
authored andcommitted
rsxx: switch from 'pci_free_consistent()' to 'dma_free_coherent()'
The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script bellow. It has been compile tested. This also aligns code with what is in use in '/rsxx/dma.c' @@ @@ - PCI_DMA_BIDIRECTIONAL + DMA_BIDIRECTIONAL @@ @@ - PCI_DMA_TODEVICE + DMA_TO_DEVICE @@ @@ - PCI_DMA_FROMDEVICE + DMA_FROM_DEVICE @@ @@ - PCI_DMA_NONE + DMA_NONE @@ expression e1, e2, e3; @@ - pci_alloc_consistent(e1, e2, e3) + dma_alloc_coherent(&e1->dev, e2, e3, GFP_) @@ expression e1, e2, e3; @@ - pci_zalloc_consistent(e1, e2, e3) + dma_alloc_coherent(&e1->dev, e2, e3, GFP_) @@ expression e1, e2, e3, e4; @@ - pci_free_consistent(e1, e2, e3, e4) + dma_free_coherent(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_map_single(e1, e2, e3, e4) + dma_map_single(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_unmap_single(e1, e2, e3, e4) + dma_unmap_single(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4, e5; @@ - pci_map_page(e1, e2, e3, e4, e5) + dma_map_page(&e1->dev, e2, e3, e4, e5) @@ expression e1, e2, e3, e4; @@ - pci_unmap_page(e1, e2, e3, e4) + dma_unmap_page(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_map_sg(e1, e2, e3, e4) + dma_map_sg(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_unmap_sg(e1, e2, e3, e4) + dma_unmap_sg(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_dma_sync_single_for_cpu(e1, e2, e3, e4) + dma_sync_single_for_cpu(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_dma_sync_single_for_device(e1, e2, e3, e4) + dma_sync_single_for_device(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_dma_sync_sg_for_cpu(e1, e2, e3, e4) + dma_sync_sg_for_cpu(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_dma_sync_sg_for_device(e1, e2, e3, e4) + dma_sync_sg_for_device(&e1->dev, e2, e3, e4) @@ expression e1, e2; @@ - pci_dma_mapping_error(e1, e2) + dma_mapping_error(&e1->dev, e2) @@ expression e1, e2; @@ - pci_set_dma_mask(e1, e2) + dma_set_mask(&e1->dev, e2) @@ expression e1, e2; @@ - pci_set_consistent_dma_mask(e1, e2) + dma_set_coherent_mask(&e1->dev, e2) Signed-off-by: Christophe JAILLET <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent 80ee071 commit 2eaac32

File tree

1 file changed

+16
-14
lines changed

1 file changed

+16
-14
lines changed

drivers/block/rsxx/core.c

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -562,13 +562,15 @@ static int rsxx_eeh_frozen(struct pci_dev *dev)
562562

563563
for (i = 0; i < card->n_targets; i++) {
564564
if (card->ctrl[i].status.buf)
565-
pci_free_consistent(card->dev, STATUS_BUFFER_SIZE8,
566-
card->ctrl[i].status.buf,
567-
card->ctrl[i].status.dma_addr);
565+
dma_free_coherent(&card->dev->dev,
566+
STATUS_BUFFER_SIZE8,
567+
card->ctrl[i].status.buf,
568+
card->ctrl[i].status.dma_addr);
568569
if (card->ctrl[i].cmd.buf)
569-
pci_free_consistent(card->dev, COMMAND_BUFFER_SIZE8,
570-
card->ctrl[i].cmd.buf,
571-
card->ctrl[i].cmd.dma_addr);
570+
dma_free_coherent(&card->dev->dev,
571+
COMMAND_BUFFER_SIZE8,
572+
card->ctrl[i].cmd.buf,
573+
card->ctrl[i].cmd.dma_addr);
572574
}
573575

574576
return 0;
@@ -711,15 +713,15 @@ static pci_ers_result_t rsxx_slot_reset(struct pci_dev *dev)
711713
failed_hw_buffers_init:
712714
for (i = 0; i < card->n_targets; i++) {
713715
if (card->ctrl[i].status.buf)
714-
pci_free_consistent(card->dev,
715-
STATUS_BUFFER_SIZE8,
716-
card->ctrl[i].status.buf,
717-
card->ctrl[i].status.dma_addr);
716+
dma_free_coherent(&card->dev->dev,
717+
STATUS_BUFFER_SIZE8,
718+
card->ctrl[i].status.buf,
719+
card->ctrl[i].status.dma_addr);
718720
if (card->ctrl[i].cmd.buf)
719-
pci_free_consistent(card->dev,
720-
COMMAND_BUFFER_SIZE8,
721-
card->ctrl[i].cmd.buf,
722-
card->ctrl[i].cmd.dma_addr);
721+
dma_free_coherent(&card->dev->dev,
722+
COMMAND_BUFFER_SIZE8,
723+
card->ctrl[i].cmd.buf,
724+
card->ctrl[i].cmd.dma_addr);
723725
}
724726
failed_hw_setup:
725727
rsxx_eeh_failure(dev);

0 commit comments

Comments
 (0)