Skip to content

Commit 2ed4b36

Browse files
Jakub Kicinskidavem330
authored andcommitted
nfp: shorten CPP core probe logs
We currently print reserved BAR mappings info as we create them. This makes the probe logs longer than necessary. Print into a buffer instead and log all the info as a single line. Signed-off-by: Jakub Kicinski <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 8b3d5a4 commit 2ed4b36

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -588,9 +588,15 @@ static int enable_bars(struct nfp6000_pcie *nfp, u16 interface)
588588
NFP_PCIE_BAR_PCIE2CPP_MapType(
589589
NFP_PCIE_BAR_PCIE2CPP_MapType_EXPLICIT3),
590590
};
591+
char status_msg[196] = {};
591592
struct nfp_bar *bar;
592593
int i, bars_free;
593594
int expl_groups;
595+
char *msg, *end;
596+
597+
msg = status_msg +
598+
snprintf(status_msg, sizeof(status_msg) - 1, "RESERVED BARs: ");
599+
end = status_msg + sizeof(status_msg) - 1;
594600

595601
bar = &nfp->bar[0];
596602
for (i = 0; i < ARRAY_SIZE(nfp->bar); i++, bar++) {
@@ -637,8 +643,7 @@ static int enable_bars(struct nfp6000_pcie *nfp, u16 interface)
637643
bar->iomem = ioremap_nocache(nfp_bar_resource_start(bar),
638644
nfp_bar_resource_len(bar));
639645
if (bar->iomem) {
640-
dev_info(nfp->dev,
641-
"BAR0.0 RESERVED: General Mapping/MSI-X SRAM\n");
646+
msg += snprintf(msg, end - msg, "0.0: General/MSI-X SRAM, ");
642647
atomic_inc(&bar->refcnt);
643648
bars_free--;
644649

@@ -665,7 +670,7 @@ static int enable_bars(struct nfp6000_pcie *nfp, u16 interface)
665670

666671
/* Configure, and lock, BAR0.1 for PCIe XPB (MSI-X PBA) */
667672
bar = &nfp->bar[1];
668-
dev_info(nfp->dev, "BAR0.1 RESERVED: PCIe XPB/MSI-X PBA\n");
673+
msg += snprintf(msg, end - msg, "0.1: PCIe XPB/MSI-X PBA, ");
669674
atomic_inc(&bar->refcnt);
670675
bars_free--;
671676

@@ -684,9 +689,8 @@ static int enable_bars(struct nfp6000_pcie *nfp, u16 interface)
684689
bar->iomem = ioremap_nocache(nfp_bar_resource_start(bar),
685690
nfp_bar_resource_len(bar));
686691
if (bar->iomem) {
687-
dev_info(nfp->dev,
688-
"BAR0.%d RESERVED: Explicit%d Mapping\n",
689-
4 + i, i);
692+
msg += snprintf(msg, end - msg,
693+
"0.%d: Explicit%d, ", 4 + i, i);
690694
atomic_inc(&bar->refcnt);
691695
bars_free--;
692696

@@ -704,8 +708,7 @@ static int enable_bars(struct nfp6000_pcie *nfp, u16 interface)
704708
sort(&nfp->bar[0], nfp->bars, sizeof(nfp->bar[0]),
705709
bar_cmp, NULL);
706710

707-
dev_info(nfp->dev, "%d NFP PCI2CPP BARs, %d free\n",
708-
nfp->bars, bars_free);
711+
dev_info(nfp->dev, "%sfree: %d/%d\n", status_msg, bars_free, nfp->bars);
709712

710713
return 0;
711714
}

0 commit comments

Comments
 (0)