Skip to content

Commit 2f4f889

Browse files
Mohsin BashirPaolo Abeni
authored andcommitted
eth: fbnic: update fbnic_poll return value
In cases where the work done is less than the budget, `fbnic_poll` is returning 0. This affects the tracing of `napi_poll`. Following is a snippet of before and after result from `napi_poll` tracepoint. Instead, returning the work done improves the manual tracing. Before: @[10]: 1 ... @[64]: 208175 @[0]: 2128008 After: @[56]: 86 @[48]: 222 ... @[5]: 1885756 @[6]: 1933841 Signed-off-by: Mohsin Bashir <[email protected]> Reviewed-by: Jakub Kicinski <[email protected]> Reviewed-by: Kalesh AP <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Paolo Abeni <[email protected]>
1 parent 097691b commit 2f4f889

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/meta/fbnic/fbnic_txrx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1033,7 +1033,7 @@ static int fbnic_poll(struct napi_struct *napi, int budget)
10331033
if (likely(napi_complete_done(napi, work_done)))
10341034
fbnic_nv_irq_rearm(nv);
10351035

1036-
return 0;
1036+
return work_done;
10371037
}
10381038

10391039
irqreturn_t fbnic_msix_clean_rings(int __always_unused irq, void *data)

0 commit comments

Comments
 (0)