Skip to content

Commit 2f726ae

Browse files
jason77-wangtiwai
authored andcommitted
ALSA: hda - fix a problem for lineout on a Dell AIO machine
On this Dell AIO machine, the lineout jack does not work. We found the pin 0x1a is assigned to lineout on this machine, and in the past, we applied ALC298_FIXUP_DELL1_MIC_NO_PRESENCE to fix the heaset-set mic problem for this machine, this fixup will redefine the pin 0x1a to headphone-mic, as a result the lineout doesn't work anymore. After consulting with Dell, they told us this machine doesn't support microphone via headset jack, so we add a new fixup which only defines the pin 0x18 as the headset-mic. [rearranged the fixup insertion position by tiwai in order to make the merge with other branches easier -- tiwai] Fixes: 59ec4b5 ("ALSA: hda - Fix headset mic detection problem for two dell machines") Cc: <[email protected]> Signed-off-by: Hui Wang <[email protected]> Signed-off-by: Takashi Iwai <[email protected]>
1 parent 9dfcce4 commit 2f726ae

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

sound/pci/hda/patch_realtek.c

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4858,6 +4858,7 @@ enum {
48584858
ALC292_FIXUP_DISABLE_AAMIX,
48594859
ALC293_FIXUP_DISABLE_AAMIX_MULTIJACK,
48604860
ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
4861+
ALC298_FIXUP_DELL_AIO_MIC_NO_PRESENCE,
48614862
ALC275_FIXUP_DELL_XPS,
48624863
ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE,
48634864
ALC293_FIXUP_LENOVO_SPK_NOISE,
@@ -5470,6 +5471,15 @@ static const struct hda_fixup alc269_fixups[] = {
54705471
.chained = true,
54715472
.chain_id = ALC269_FIXUP_HEADSET_MODE
54725473
},
5474+
[ALC298_FIXUP_DELL_AIO_MIC_NO_PRESENCE] = {
5475+
.type = HDA_FIXUP_PINS,
5476+
.v.pins = (const struct hda_pintbl[]) {
5477+
{ 0x18, 0x01a1913c }, /* use as headset mic, without its own jack detect */
5478+
{ }
5479+
},
5480+
.chained = true,
5481+
.chain_id = ALC269_FIXUP_HEADSET_MODE
5482+
},
54735483
[ALC275_FIXUP_DELL_XPS] = {
54745484
.type = HDA_FIXUP_VERBS,
54755485
.v.verbs = (const struct hda_verb[]) {
@@ -5542,7 +5552,7 @@ static const struct hda_fixup alc269_fixups[] = {
55425552
.type = HDA_FIXUP_FUNC,
55435553
.v.func = alc298_fixup_speaker_volume,
55445554
.chained = true,
5545-
.chain_id = ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
5555+
.chain_id = ALC298_FIXUP_DELL_AIO_MIC_NO_PRESENCE,
55465556
},
55475557
[ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER] = {
55485558
.type = HDA_FIXUP_PINS,

0 commit comments

Comments
 (0)