Skip to content

Commit 2ffdc9a

Browse files
AxelLinThierry Reding
authored andcommitted
pwm: Remove a redundant error message when devm_request_and_ioremap fails
The implementation in devm_request_and_ioremap() already shows error message, so no need to show dev_err again if devm_request_and_ioremap() fails. Signed-off-by: Axel Lin <[email protected]> Cc: Stephen Warren <[email protected]> Cc: Philip, Avinash <[email protected]> Signed-off-by: Thierry Reding <[email protected]>
1 parent ecefeb7 commit 2ffdc9a

File tree

3 files changed

+3
-9
lines changed

3 files changed

+3
-9
lines changed

drivers/pwm/pwm-tegra.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,10 +187,8 @@ static int tegra_pwm_probe(struct platform_device *pdev)
187187
}
188188

189189
pwm->mmio_base = devm_request_and_ioremap(&pdev->dev, r);
190-
if (!pwm->mmio_base) {
191-
dev_err(&pdev->dev, "failed to ioremap() region\n");
190+
if (!pwm->mmio_base)
192191
return -EADDRNOTAVAIL;
193-
}
194192

195193
platform_set_drvdata(pdev, pwm);
196194

drivers/pwm/pwm-tiecap.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -192,10 +192,8 @@ static int __devinit ecap_pwm_probe(struct platform_device *pdev)
192192
}
193193

194194
pc->mmio_base = devm_request_and_ioremap(&pdev->dev, r);
195-
if (!pc->mmio_base) {
196-
dev_err(&pdev->dev, "failed to ioremap() registers\n");
195+
if (!pc->mmio_base)
197196
return -EADDRNOTAVAIL;
198-
}
199197

200198
ret = pwmchip_add(&pc->chip);
201199
if (ret < 0) {

drivers/pwm/pwm-tiehrpwm.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -371,10 +371,8 @@ static int __devinit ehrpwm_pwm_probe(struct platform_device *pdev)
371371
}
372372

373373
pc->mmio_base = devm_request_and_ioremap(&pdev->dev, r);
374-
if (!pc->mmio_base) {
375-
dev_err(&pdev->dev, "failed to ioremap() registers\n");
374+
if (!pc->mmio_base)
376375
return -EADDRNOTAVAIL;
377-
}
378376

379377
ret = pwmchip_add(&pc->chip);
380378
if (ret < 0) {

0 commit comments

Comments
 (0)