net: inet_is_local_reserved_port() should return bool not int

zenczykowski · Jakub Kicinski · commit 30429fba99b5 · 2019-11-22T16:52:47.000-08:00
Cc: Eric Dumazet &lt;edumazet@google.com&gt;
Signed-off-by: Maciej Żenczykowski &lt;maze@google.com&gt;
Signed-off-by: Jakub Kicinski &lt;jakub.kicinski@netronome.com&gt;
diff --git a/include/net/ip.h b/include/net/ip.h
@@ -339,10 +339,10 @@ static inline u64 snmp_fold_field64(void __percpu *mib, int offt, size_t syncp_o
 void inet_get_local_port_range(struct net *net, int *low, int *high);
 
 #ifdef CONFIG_SYSCTL
-static inline int inet_is_local_reserved_port(struct net *net, int port)
+static inline bool inet_is_local_reserved_port(struct net *net, int port)
 {
 	if (!net->ipv4.sysctl_local_reserved_ports)
-		return 0;
+		return false;
 	return test_bit(port, net->ipv4.sysctl_local_reserved_ports);
 }
 
@@ -357,9 +357,9 @@ static inline int inet_prot_sock(struct net *net)
 }
 
 #else
-static inline int inet_is_local_reserved_port(struct net *net, int port)
+static inline bool inet_is_local_reserved_port(struct net *net, int port)
 {
-	return 0;
+	return false;
 }
 
 static inline int inet_prot_sock(struct net *net)

Original file line number	Diff line number	Diff line change
`@@ -339,10 +339,10 @@ static inline u64 snmp_fold_field64(void __percpu *mib, int offt, size_t syncp_o`
`339`	`339`	`void inet_get_local_port_range(struct net net, int low, int *high);`
`340`	`340`
`341`	`341`	`#ifdef CONFIG_SYSCTL`
`342`		`-static inline int inet_is_local_reserved_port(struct net *net, int port)`
	`342`	`+static inline bool inet_is_local_reserved_port(struct net *net, int port)`
`343`	`343`	`{`
`344`	`344`	`if (!net->ipv4.sysctl_local_reserved_ports)`
`345`		`- return 0;`
	`345`	`+ return false;`
`346`	`346`	`return test_bit(port, net->ipv4.sysctl_local_reserved_ports);`
`347`	`347`	`}`
`348`	`348`
`@@ -357,9 +357,9 @@ static inline int inet_prot_sock(struct net *net)`
`357`	`357`	`}`
`358`	`358`
`359`	`359`	`#else`
`360`		`-static inline int inet_is_local_reserved_port(struct net *net, int port)`
	`360`	`+static inline bool inet_is_local_reserved_port(struct net *net, int port)`
`361`	`361`	`{`
`362`		`- return 0;`
	`362`	`+ return false;`
`363`	`363`	`}`
`364`	`364`
`365`	`365`	`static inline int inet_prot_sock(struct net *net)`