Skip to content

Commit 31184d8

Browse files
gclementWolfram Sang
authored andcommitted
i2c: mv64xxx: Apply errata delay only in standard mode
The errata FE-8471889 description has been updated. There is still a timing violation for repeated start. But the errata now states that it was only the case for the Standard mode (100 kHz), in Fast mode (400 kHz) there is no issue. This patch limit the errata fix to the Standard mode. It has been tesed successfully on the clearfog (Aramda 388 based board). Signed-off-by: Gregory CLEMENT <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent 74d2331 commit 31184d8

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

drivers/i2c/busses/i2c-mv64xxx.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -845,12 +845,16 @@ mv64xxx_of_config(struct mv64xxx_i2c_data *drv_data,
845845
*/
846846
if (of_device_is_compatible(np, "marvell,mv78230-i2c")) {
847847
drv_data->offload_enabled = true;
848-
drv_data->errata_delay = true;
848+
/* The delay is only needed in standard mode (100kHz) */
849+
if (bus_freq <= 100000)
850+
drv_data->errata_delay = true;
849851
}
850852

851853
if (of_device_is_compatible(np, "marvell,mv78230-a0-i2c")) {
852854
drv_data->offload_enabled = false;
853-
drv_data->errata_delay = true;
855+
/* The delay is only needed in standard mode (100kHz) */
856+
if (bus_freq <= 100000)
857+
drv_data->errata_delay = true;
854858
}
855859

856860
if (of_device_is_compatible(np, "allwinner,sun6i-a31-i2c"))

0 commit comments

Comments
 (0)