Skip to content

Commit 312324f

Browse files
Jakub Kicinskidavem330
authored andcommitted
bnxt: use tc_cls_can_offload_and_chain0()
Make use of tc_cls_can_offload_and_chain0() to set extack msg in case ethtool tc offload flag is not set or chain unsupported. Signed-off-by: Jakub Kicinski <[email protected]> Reviewed-by: Simon Horman <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 9ab88e8 commit 312324f

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7778,7 +7778,8 @@ static int bnxt_setup_tc_block_cb(enum tc_setup_type type, void *type_data,
77787778
{
77797779
struct bnxt *bp = cb_priv;
77807780

7781-
if (!bnxt_tc_flower_enabled(bp) || !tc_can_offload(bp->dev))
7781+
if (!bnxt_tc_flower_enabled(bp) ||
7782+
!tc_cls_can_offload_and_chain0(bp->dev, type_data))
77827783
return -EOPNOTSUPP;
77837784

77847785
switch (type) {

drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1474,9 +1474,6 @@ int bnxt_tc_setup_flower(struct bnxt *bp, u16 src_fid,
14741474
{
14751475
int rc = 0;
14761476

1477-
if (cls_flower->common.chain_index)
1478-
return -EOPNOTSUPP;
1479-
14801477
switch (cls_flower->command) {
14811478
case TC_CLSFLOWER_REPLACE:
14821479
rc = bnxt_tc_add_flow(bp, src_fid, cls_flower);

drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,8 @@ static int bnxt_vf_rep_setup_tc_block_cb(enum tc_setup_type type,
124124
struct bnxt *bp = vf_rep->bp;
125125
int vf_fid = bp->pf.vf[vf_rep->vf_idx].fw_fid;
126126

127-
if (!bnxt_tc_flower_enabled(vf_rep->bp) || !tc_can_offload(bp->dev))
127+
if (!bnxt_tc_flower_enabled(vf_rep->bp) ||
128+
!tc_cls_can_offload_and_chain0(bp->dev, type_data))
128129
return -EOPNOTSUPP;
129130

130131
switch (type) {

0 commit comments

Comments
 (0)