Skip to content

Commit 3124034

Browse files
jasowangdavem330
authored andcommitted
virtio-net: add packet len average only when needed during XDP
There's no need to add packet len average in the case of XDP_PASS since it will be done soon after skb is created. Cc: John Fastabend <[email protected]> Signed-off-by: Jason Wang <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 9457642 commit 3124034

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/net/virtio_net.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -656,6 +656,9 @@ static struct sk_buff *receive_mergeable(struct net_device *dev,
656656
xdp.data_end = xdp.data + (len - vi->hdr_len);
657657
act = bpf_prog_run_xdp(xdp_prog, &xdp);
658658

659+
if (act != XDP_PASS)
660+
ewma_pkt_len_add(&rq->mrg_avg_pkt_len, len);
661+
659662
switch (act) {
660663
case XDP_PASS:
661664
/* recalculate offset to account for any header
@@ -671,14 +674,12 @@ static struct sk_buff *receive_mergeable(struct net_device *dev,
671674
put_page(page);
672675
head_skb = page_to_skb(vi, rq, xdp_page,
673676
offset, len, PAGE_SIZE);
674-
ewma_pkt_len_add(&rq->mrg_avg_pkt_len, len);
675677
return head_skb;
676678
}
677679
break;
678680
case XDP_TX:
679681
if (unlikely(!virtnet_xdp_xmit(vi, &xdp)))
680682
trace_xdp_exception(vi->dev, xdp_prog, act);
681-
ewma_pkt_len_add(&rq->mrg_avg_pkt_len, len);
682683
if (unlikely(xdp_page != page))
683684
goto err_xdp;
684685
rcu_read_unlock();
@@ -690,7 +691,6 @@ static struct sk_buff *receive_mergeable(struct net_device *dev,
690691
case XDP_DROP:
691692
if (unlikely(xdp_page != page))
692693
__free_pages(xdp_page, 0);
693-
ewma_pkt_len_add(&rq->mrg_avg_pkt_len, len);
694694
goto err_xdp;
695695
}
696696
}

0 commit comments

Comments
 (0)