tcp: allow to enable the repair mode for non-listening sockets

avagin · davem330 · commit 319b0534b958 · 2016-11-15T22:28:50.000-05:00
The repair mode is used to get and restore sequence numbers and
data from queues. It used to checkpoint/restore connections.

Currently the repair mode can be enabled for sockets in the established
and closed states, but for other states we have to dump the same socket
properties, so lets allow to enable repair mode for these sockets.

The repair mode reveals nothing more for sockets in other states.

Signed-off-by: Andrei Vagin &lt;avagin@openvz.org&gt;
Acked-by: Pavel Emelyanov &lt;xemul@openvz.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
@@ -2300,7 +2300,7 @@ EXPORT_SYMBOL(tcp_disconnect);
 static inline bool tcp_can_repair_sock(const struct sock *sk)
 {
 	return ns_capable(sock_net(sk)->user_ns, CAP_NET_ADMIN) &&
-		((1 << sk->sk_state) & (TCPF_CLOSE | TCPF_ESTABLISHED));
+		(sk->sk_state != TCP_LISTEN);
 }
 
 static int tcp_repair_set_window(struct tcp_sock *tp, char __user *optbuf, int len)

Original file line number	Diff line number	Diff line change
`@@ -2300,7 +2300,7 @@ EXPORT_SYMBOL(tcp_disconnect);`
`2300`	`2300`	`static inline bool tcp_can_repair_sock(const struct sock *sk)`
`2301`	`2301`	`{`
`2302`	`2302`	`return ns_capable(sock_net(sk)->user_ns, CAP_NET_ADMIN) &&`
`2303`		`- ((1 << sk->sk_state) & (TCPF_CLOSE \| TCPF_ESTABLISHED));`
	`2303`	`+ (sk->sk_state != TCP_LISTEN);`
`2304`	`2304`	`}`
`2305`	`2305`
`2306`	`2306`	`static int tcp_repair_set_window(struct tcp_sock tp, char __user optbuf, int len)`