ipv4: fix rcu lock imbalance in fib_select_default()

Eric Dumazet · davem330 · commit 31d409373cca · 2011-02-14T11:23:04.000-08:00
Commit 0c838ff (ipv4: Consolidate all default route selection implementations.) forgot to remove one rcu_read_unlock() from fib_select_default(). Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
@@ -1189,7 +1189,7 @@ void fib_select_default(struct fib_result *res)
 		fib_result_assign(res, last_resort);
 	tb->tb_default = last_idx;
 out:
-	rcu_read_unlock();
+	return;
 }
 
 #ifdef CONFIG_IP_ROUTE_MULTIPATH

Original file line number	Diff line number	Diff line change
`@@ -1189,7 +1189,7 @@ void fib_select_default(struct fib_result *res)`
`1189`	`1189`	`fib_result_assign(res, last_resort);`
`1190`	`1190`	`tb->tb_default = last_idx;`
`1191`	`1191`	`out:`
`1192`		`- rcu_read_unlock();`
	`1192`	`+ return;`
`1193`	`1193`	`}`
`1194`	`1194`
`1195`	`1195`	`#ifdef CONFIG_IP_ROUTE_MULTIPATH`