Skip to content

Commit 3256aae

Browse files
Vincent Stehlésagigrimberg
authored andcommitted
nvmet-rdma: Fix use after free
Avoid dereferencing the queue pointer in nvmet_rdma_release_queue_work() after it has been freed by nvmet_rdma_free_queue(). Fixes: d8f7750 ("nvmet-rdma: Correctly handle RDMA device hot removal") Signed-off-by: Vincent Stehlé <[email protected]> Cc: Sagi Grimberg <[email protected]> Cc: Christoph Hellwig <[email protected]> Signed-off-by: Sagi Grimberg <[email protected]>
1 parent 39bbee4 commit 3256aae

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/nvme/target/rdma.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -978,10 +978,11 @@ static void nvmet_rdma_release_queue_work(struct work_struct *w)
978978
container_of(w, struct nvmet_rdma_queue, release_work);
979979
struct rdma_cm_id *cm_id = queue->cm_id;
980980
struct nvmet_rdma_device *dev = queue->dev;
981+
enum nvmet_rdma_queue_state state = queue->state;
981982

982983
nvmet_rdma_free_queue(queue);
983984

984-
if (queue->state != NVMET_RDMA_IN_DEVICE_REMOVAL)
985+
if (state != NVMET_RDMA_IN_DEVICE_REMOVAL)
985986
rdma_destroy_id(cm_id);
986987

987988
kref_put(&dev->ref, nvmet_rdma_free_dev);

0 commit comments

Comments
 (0)