Skip to content

Commit 32c0097

Browse files
pbholeborkmann
authored andcommitted
samples/bpf: fix compilation failure
following commit: commit d58e468 ("flow_dissector: implements flow dissector BPF hook") added struct bpf_flow_keys which conflicts with the struct with same name in sockex2_kern.c and sockex3_kern.c similar to commit: commit 534e0e5 ("samples/bpf: fix a compilation failure") we tried the rename it "flow_keys" but it also conflicted with struct having same name in include/net/flow_dissector.h. Hence renaming the struct to "flow_key_record". Also, this commit doesn't fix the compilation error completely because the similar struct is present in sockex3_kern.c. Hence renaming it in both files sockex3_user.c and sockex3_kern.c Signed-off-by: Prashant Bhole <[email protected]> Acked-by: Song Liu <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]>
1 parent 2dfd184 commit 32c0097

File tree

3 files changed

+12
-11
lines changed

3 files changed

+12
-11
lines changed

samples/bpf/sockex2_kern.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ struct vlan_hdr {
1414
__be16 h_vlan_encapsulated_proto;
1515
};
1616

17-
struct bpf_flow_keys {
17+
struct flow_key_record {
1818
__be32 src;
1919
__be32 dst;
2020
union {
@@ -59,7 +59,7 @@ static inline __u32 ipv6_addr_hash(struct __sk_buff *ctx, __u64 off)
5959
}
6060

6161
static inline __u64 parse_ip(struct __sk_buff *skb, __u64 nhoff, __u64 *ip_proto,
62-
struct bpf_flow_keys *flow)
62+
struct flow_key_record *flow)
6363
{
6464
__u64 verlen;
6565

@@ -83,7 +83,7 @@ static inline __u64 parse_ip(struct __sk_buff *skb, __u64 nhoff, __u64 *ip_proto
8383
}
8484

8585
static inline __u64 parse_ipv6(struct __sk_buff *skb, __u64 nhoff, __u64 *ip_proto,
86-
struct bpf_flow_keys *flow)
86+
struct flow_key_record *flow)
8787
{
8888
*ip_proto = load_byte(skb,
8989
nhoff + offsetof(struct ipv6hdr, nexthdr));
@@ -96,7 +96,8 @@ static inline __u64 parse_ipv6(struct __sk_buff *skb, __u64 nhoff, __u64 *ip_pro
9696
return nhoff;
9797
}
9898

99-
static inline bool flow_dissector(struct __sk_buff *skb, struct bpf_flow_keys *flow)
99+
static inline bool flow_dissector(struct __sk_buff *skb,
100+
struct flow_key_record *flow)
100101
{
101102
__u64 nhoff = ETH_HLEN;
102103
__u64 ip_proto;
@@ -198,7 +199,7 @@ struct bpf_map_def SEC("maps") hash_map = {
198199
SEC("socket2")
199200
int bpf_prog2(struct __sk_buff *skb)
200201
{
201-
struct bpf_flow_keys flow = {};
202+
struct flow_key_record flow = {};
202203
struct pair *value;
203204
u32 key;
204205

samples/bpf/sockex3_kern.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ struct vlan_hdr {
6161
__be16 h_vlan_encapsulated_proto;
6262
};
6363

64-
struct bpf_flow_keys {
64+
struct flow_key_record {
6565
__be32 src;
6666
__be32 dst;
6767
union {
@@ -88,7 +88,7 @@ static inline __u32 ipv6_addr_hash(struct __sk_buff *ctx, __u64 off)
8888
}
8989

9090
struct globals {
91-
struct bpf_flow_keys flow;
91+
struct flow_key_record flow;
9292
};
9393

9494
struct bpf_map_def SEC("maps") percpu_map = {
@@ -114,14 +114,14 @@ struct pair {
114114

115115
struct bpf_map_def SEC("maps") hash_map = {
116116
.type = BPF_MAP_TYPE_HASH,
117-
.key_size = sizeof(struct bpf_flow_keys),
117+
.key_size = sizeof(struct flow_key_record),
118118
.value_size = sizeof(struct pair),
119119
.max_entries = 1024,
120120
};
121121

122122
static void update_stats(struct __sk_buff *skb, struct globals *g)
123123
{
124-
struct bpf_flow_keys key = g->flow;
124+
struct flow_key_record key = g->flow;
125125
struct pair *value;
126126

127127
value = bpf_map_lookup_elem(&hash_map, &key);

samples/bpf/sockex3_user.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
#define PARSE_IP_PROG_FD (prog_fd[0])
1414
#define PROG_ARRAY_FD (map_fd[0])
1515

16-
struct flow_keys {
16+
struct flow_key_record {
1717
__be32 src;
1818
__be32 dst;
1919
union {
@@ -64,7 +64,7 @@ int main(int argc, char **argv)
6464
(void) f;
6565

6666
for (i = 0; i < 5; i++) {
67-
struct flow_keys key = {}, next_key;
67+
struct flow_key_record key = {}, next_key;
6868
struct pair value;
6969

7070
sleep(1);

0 commit comments

Comments
 (0)