Skip to content

Commit 32d7b19

Browse files
committed
platform/x86: dell-smbios: Resolve dependency error on DCDBAS
When the DELL_SMBIOS_SMM backend is enabled, the DELL_SMBIOS symbol depends on DELL_DCDBAS, and we must avoid the situation where DELL_SMBIOS=y and DCDBAS=m. Adding the conditional dependency to DELL_SMBIOS such as: depends !DELL_SMBIOS_SMM || (DCDBAS || DCDBAS=n) results in the Kconfig tooling complaining about a circular dependency, although it appears to work in practice. Avoid the errors by simplifying the dependency and forcing DELL_SMBIOS to be <= DCDBAS if DCDBAS is enabled (thanks to Greg KH for the suggestion). Cc: [email protected] Signed-off-by: Darren Hart (VMware) <[email protected]>
1 parent 329d58b commit 32d7b19

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

drivers/platform/x86/Kconfig

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,14 @@ config ASUS_LAPTOP
105105

106106
If you have an ACPI-compatible ASUS laptop, say Y or M here.
107107

108+
#
109+
# If the DELL_SMBIOS_SMM feature is enabled, the DELL_SMBIOS driver
110+
# becomes dependent on the DCDBAS driver. The "depends" line prevents a
111+
# configuration where DELL_SMBIOS=y while DCDBAS=m.
112+
#
108113
config DELL_SMBIOS
109114
tristate "Dell SMBIOS driver"
115+
depends on DCDBAS || DCDBAS=n
110116
---help---
111117
This provides support for the Dell SMBIOS calling interface.
112118
If you have a Dell computer you should enable this option.

0 commit comments

Comments
 (0)