net: fix warning in af_unix

Kyeongdon Kim · davem330 · commit 33c4368ee258 · 2018-10-17T21:57:28.000-07:00
This fixes the "'hash' may be used uninitialized in this function"

net/unix/af_unix.c:1041:20: warning: 'hash' may be used uninitialized in this function [-Wmaybe-uninitialized]
  addr-&gt;hash = hash ^ sk-&gt;sk_type;

Signed-off-by: Kyeongdon Kim &lt;kyeongdon.kim@lge.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
@@ -225,6 +225,8 @@ static inline void unix_release_addr(struct unix_address *addr)
 
 static int unix_mkname(struct sockaddr_un *sunaddr, int len, unsigned int *hashp)
 {
+	*hashp = 0;
+
 	if (len <= sizeof(short) || len > sizeof(*sunaddr))
 		return -EINVAL;
 	if (!sunaddr || sunaddr->sun_family != AF_UNIX)

Original file line number	Diff line number	Diff line change
`@@ -225,6 +225,8 @@ static inline void unix_release_addr(struct unix_address *addr)`
`225`	`225`
`226`	`226`	`static int unix_mkname(struct sockaddr_un sunaddr, int len, unsigned int hashp)`
`227`	`227`	`{`
	`228`	`+ *hashp = 0;`
	`229`	`+`
`228`	`230`	`if (len <= sizeof(short) \|\| len > sizeof(*sunaddr))`
`229`	`231`	`return -EINVAL;`
`230`	`232`	`if (!sunaddr \|\| sunaddr->sun_family != AF_UNIX)`