Skip to content

Commit 345af95

Browse files
committed
Merge branch 'for-davem' of git://gitorious.org/linux-can/linux-can-next
Marc Kleine-Budde says: ==================== this is a pull-request for net-next/master. It consists of 4 patches by Jingoo Han, which remove the unnecessary platform_set_drvdata() and a patch by Laurent Navet converting the grcan driver to use devm_ioremap_resource(). ==================== Signed-off-by: David S. Miller <[email protected]>
2 parents ed8a83a + 5727dc6 commit 345af95

File tree

5 files changed

+3
-10
lines changed

5 files changed

+3
-10
lines changed

drivers/net/can/at91_can.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1393,8 +1393,6 @@ static int at91_can_remove(struct platform_device *pdev)
13931393

13941394
unregister_netdev(dev);
13951395

1396-
platform_set_drvdata(pdev, NULL);
1397-
13981396
iounmap(priv->reg_base);
13991397

14001398
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

drivers/net/can/c_can/c_can_platform.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,6 @@ static int c_can_plat_probe(struct platform_device *pdev)
234234
return 0;
235235

236236
exit_free_device:
237-
platform_set_drvdata(pdev, NULL);
238237
free_c_can_dev(dev);
239238
exit_iounmap:
240239
iounmap(addr);
@@ -255,7 +254,6 @@ static int c_can_plat_remove(struct platform_device *pdev)
255254
struct resource *mem;
256255

257256
unregister_c_can_dev(dev);
258-
platform_set_drvdata(pdev, NULL);
259257

260258
free_c_can_dev(dev);
261259
iounmap(priv->base);

drivers/net/can/flexcan.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1127,7 +1127,6 @@ static int flexcan_remove(struct platform_device *pdev)
11271127
struct resource *mem;
11281128

11291129
unregister_flexcandev(dev);
1130-
platform_set_drvdata(pdev, NULL);
11311130
iounmap(priv->base);
11321131

11331132
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);

drivers/net/can/grcan.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1683,10 +1683,9 @@ static int grcan_probe(struct platform_device *ofdev)
16831683
}
16841684

16851685
res = platform_get_resource(ofdev, IORESOURCE_MEM, 0);
1686-
base = devm_request_and_ioremap(&ofdev->dev, res);
1687-
if (!base) {
1688-
dev_err(&ofdev->dev, "couldn't map IO resource\n");
1689-
err = -EADDRNOTAVAIL;
1686+
base = devm_ioremap_resource(&ofdev->dev, res);
1687+
if (IS_ERR(base)) {
1688+
err = PTR_ERR(base);
16901689
goto exit_error;
16911690
}
16921691

drivers/net/can/ti_hecc.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1001,7 +1001,6 @@ static int ti_hecc_remove(struct platform_device *pdev)
10011001
iounmap(priv->base);
10021002
release_mem_region(res->start, resource_size(res));
10031003
free_candev(ndev);
1004-
platform_set_drvdata(pdev, NULL);
10051004

10061005
return 0;
10071006
}

0 commit comments

Comments
 (0)