Skip to content

Commit 34aacb2

Browse files
committed
procfs: Use generic_file_llseek in /proc/kcore
/proc/kcore has no llseek and then falls down to use default_llseek. This is racy against read_kcore() that directly manipulates fpos but it doesn't hold the bkl there so using it in llseek doesn't protect anything. Let's use generic_file_llseek() instead. Signed-off-by: Frederic Weisbecker <[email protected]> Acked-by: Arnd Bergmann <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: Andrew Morton <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: John Kacur <[email protected]> Cc: KAMEZAWA Hiroyuki <[email protected]> Cc: Al Viro <[email protected]>
1 parent 87df842 commit 34aacb2

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

fs/proc/kcore.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -557,6 +557,7 @@ static int open_kcore(struct inode *inode, struct file *filp)
557557
static const struct file_operations proc_kcore_operations = {
558558
.read = read_kcore,
559559
.open = open_kcore,
560+
.llseek = generic_file_llseek,
560561
};
561562

562563
#ifdef CONFIG_MEMORY_HOTPLUG

0 commit comments

Comments
 (0)