Skip to content

Commit 34ad129

Browse files
Michal Hockotorvalds
authored andcommitted
mm, memory_hotplug: remove explicit build_all_zonelists from try_online_node
try_online_node calls hotadd_new_pgdat which already calls build_all_zonelists. So the additional call is redundant. Even though hotadd_new_pgdat will only initialize zonelists of the new node this is the right thing to do because such a node doesn't have any memory so other zonelists would ignore all the zones from this node anyway. Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Michal Hocko <[email protected]> Acked-by: Vlastimil Babka <[email protected]> Cc: Toshi Kani <[email protected]> Cc: Johannes Weiner <[email protected]> Cc: Joonsoo Kim <[email protected]> Cc: Mel Gorman <[email protected]> Cc: Shaohua Li <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 72675e1 commit 34ad129

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

mm/memory_hotplug.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1081,13 +1081,6 @@ int try_online_node(int nid)
10811081
node_set_online(nid);
10821082
ret = register_one_node(nid);
10831083
BUG_ON(ret);
1084-
1085-
if (pgdat->node_zonelists->_zonerefs->zone == NULL) {
1086-
mutex_lock(&zonelists_mutex);
1087-
build_all_zonelists(NULL);
1088-
mutex_unlock(&zonelists_mutex);
1089-
}
1090-
10911084
out:
10921085
mem_hotplug_done();
10931086
return ret;

0 commit comments

Comments
 (0)