USB: TI 3410/5052 USB Serial Driver: Fix mem leak when firmware is too big.

jjuhl · gregkh · commit 357f45db9203 · 2011-06-14T14:20:30.000-07:00
If the size of the firmware exceeds TI_FIRMWARE_BUF_SIZE we'll leak 'fw_p'
by failing to call release_firmware().
This patch fixes the leak.

Signed-off-by: Jesper Juhl &lt;jj@chaosbits.net&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c
@@ -1745,6 +1745,7 @@ static int ti_download_firmware(struct ti_device *tdev)
 	}
 	if (fw_p->size > TI_FIRMWARE_BUF_SIZE) {
 		dev_err(&dev->dev, "%s - firmware too large %zu\n", __func__, fw_p->size);
+		release_firmware(fw_p);
 		return -ENOENT;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1745,6 +1745,7 @@ static int ti_download_firmware(struct ti_device *tdev)`
`1745`	`1745`	`}`
`1746`	`1746`	`if (fw_p->size > TI_FIRMWARE_BUF_SIZE) {`
`1747`	`1747`	`dev_err(&dev->dev, "%s - firmware too large %zu\n", __func__, fw_p->size);`
	`1748`	`+ release_firmware(fw_p);`
`1748`	`1749`	`return -ENOENT;`
`1749`	`1750`	`}`
`1750`	`1751`