Skip to content

Commit 35cd781

Browse files
Rik van Rieltorvalds
authored andcommitted
vmscan: throttle direct reclaim when too many pages are isolated already
When way too many processes go into direct reclaim, it is possible for all of the pages to be taken off the LRU. One result of this is that the next process in the page reclaim code thinks there are no reclaimable pages left and triggers an out of memory kill. One solution to this problem is to never let so many processes into the page reclaim path that the entire LRU is emptied. Limiting the system to only having half of each inactive list isolated for reclaim should be safe. Signed-off-by: Rik van Riel <[email protected]> Cc: KOSAKI Motohiro <[email protected]> Cc: Wu Fengguang <[email protected]> Cc: KAMEZAWA Hiroyuki <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent a731286 commit 35cd781

File tree

1 file changed

+33
-0
lines changed

1 file changed

+33
-0
lines changed

mm/vmscan.c

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1033,6 +1033,31 @@ int isolate_lru_page(struct page *page)
10331033
return ret;
10341034
}
10351035

1036+
/*
1037+
* Are there way too many processes in the direct reclaim path already?
1038+
*/
1039+
static int too_many_isolated(struct zone *zone, int file,
1040+
struct scan_control *sc)
1041+
{
1042+
unsigned long inactive, isolated;
1043+
1044+
if (current_is_kswapd())
1045+
return 0;
1046+
1047+
if (!scanning_global_lru(sc))
1048+
return 0;
1049+
1050+
if (file) {
1051+
inactive = zone_page_state(zone, NR_INACTIVE_FILE);
1052+
isolated = zone_page_state(zone, NR_ISOLATED_FILE);
1053+
} else {
1054+
inactive = zone_page_state(zone, NR_INACTIVE_ANON);
1055+
isolated = zone_page_state(zone, NR_ISOLATED_ANON);
1056+
}
1057+
1058+
return isolated > inactive;
1059+
}
1060+
10361061
/*
10371062
* shrink_inactive_list() is a helper for shrink_zone(). It returns the number
10381063
* of reclaimed pages
@@ -1048,6 +1073,14 @@ static unsigned long shrink_inactive_list(unsigned long max_scan,
10481073
struct zone_reclaim_stat *reclaim_stat = get_reclaim_stat(zone, sc);
10491074
int lumpy_reclaim = 0;
10501075

1076+
while (unlikely(too_many_isolated(zone, file, sc))) {
1077+
congestion_wait(WRITE, HZ/10);
1078+
1079+
/* We are about to die and free our memory. Return now. */
1080+
if (fatal_signal_pending(current))
1081+
return SWAP_CLUSTER_MAX;
1082+
}
1083+
10511084
/*
10521085
* If we need a large contiguous chunk of memory, or have
10531086
* trouble getting a small set of contiguous pages, we

0 commit comments

Comments
 (0)