Skip to content

Commit 3637f12

Browse files
Anson-HuangShawn Guo
authored andcommitted
soc: imx: gpcv2: correct PGC offset
Correct MIPI/PCIe/USB_HSIC's PGC offset based on design RTL, the values in the Reference Manual (Rev. 1, 01/2018 and the older ones) are incorrect. The correct offset values should be as below: 0x800 ~ 0x83F: PGC for core0 of A7 platform; 0x840 ~ 0x87F: PGC for core1 of A7 platform; 0x880 ~ 0x8BF: PGC for SCU of A7 platform; 0xA00 ~ 0xA3F: PGC for fastmix/megamix; 0xC00 ~ 0xC3F: PGC for MIPI PHY; 0xC40 ~ 0xC7F: PGC for PCIe_PHY; 0xC80 ~ 0xCBF: PGC for USB OTG1 PHY; 0xCC0 ~ 0xCFF: PGC for USB OTG2 PHY; 0xD00 ~ 0xD3F: PGC for USB HSIC PHY; Signed-off-by: Anson Huang <[email protected]> Fixes: 03aa126 ("soc: imx: Add GPCv2 power gating driver") Acked-by: Andrey Smirnov <[email protected]> Reviewed-by: Fabio Estevam <[email protected]> Signed-off-by: Shawn Guo <[email protected]>
1 parent df07101 commit 3637f12

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

drivers/soc/imx/gpcv2.c

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,15 @@
3939

4040
#define GPC_M4_PU_PDN_FLG 0x1bc
4141

42-
43-
#define PGC_MIPI 4
44-
#define PGC_PCIE 5
45-
#define PGC_USB_HSIC 8
42+
/*
43+
* The PGC offset values in Reference Manual
44+
* (Rev. 1, 01/2018 and the older ones) GPC chapter's
45+
* GPC_PGC memory map are incorrect, below offset
46+
* values are from design RTL.
47+
*/
48+
#define PGC_MIPI 16
49+
#define PGC_PCIE 17
50+
#define PGC_USB_HSIC 20
4651
#define GPC_PGC_CTRL(n) (0x800 + (n) * 0x40)
4752
#define GPC_PGC_SR(n) (GPC_PGC_CTRL(n) + 0xc)
4853

0 commit comments

Comments
 (0)