Skip to content

Commit 3662cd1

Browse files
author
Thomas Zimmermann
committed
drm/vboxvideo: Set up fbdev after registering device; remove error checks
Generic fbdev support is a DRM client. Set it up after registering the new DRM device. Remove the error checks as the driver's probe function should not depend on a DRM client's state. Signed-off-by: Thomas Zimmermann <[email protected]> Reviewed-by: Noralf Trønnes <[email protected]> Acked-by: Sam Ravnborg <[email protected]> Acked-by: Gerd Hoffmann <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 66459fa commit 3662cd1

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/gpu/drm/vboxvideo/vbox_drv.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,14 +78,12 @@ static int vbox_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
7878
if (ret)
7979
goto err_mode_fini;
8080

81-
ret = drm_fbdev_generic_setup(&vbox->ddev, 32);
82-
if (ret)
83-
goto err_irq_fini;
84-
8581
ret = drm_dev_register(&vbox->ddev, 0);
8682
if (ret)
8783
goto err_irq_fini;
8884

85+
drm_fbdev_generic_setup(&vbox->ddev, 32);
86+
8987
return 0;
9088

9189
err_irq_fini:

0 commit comments

Comments
 (0)