Skip to content

Commit 37ef164

Browse files
committed
Merge tag 'driver-core-4.1-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core
Pull driver core fixes from Greg KH: "Here are two fixes for the driver core that resolve some reported issues. One is a regression from 4.0, the other a fixes a reported oops that has been there since 3.19. Both have been in linux-next for a while with no problems" * tag 'driver-core-4.1-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core: drivers/base: cacheinfo: handle absence of caches drivers: of/base: move of_init to driver_init
2 parents eadc21f + 3370e13 commit 37ef164

File tree

4 files changed

+12
-6
lines changed

4 files changed

+12
-6
lines changed

drivers/base/cacheinfo.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ static int detect_cache_attributes(unsigned int cpu)
179179
{
180180
int ret;
181181

182-
if (init_cache_level(cpu))
182+
if (init_cache_level(cpu) || !cache_leaves(cpu))
183183
return -ENOENT;
184184

185185
per_cpu_cacheinfo(cpu) = kcalloc(cache_leaves(cpu),

drivers/base/init.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
#include <linux/device.h>
99
#include <linux/init.h>
1010
#include <linux/memory.h>
11+
#include <linux/of.h>
1112

1213
#include "base.h"
1314

@@ -34,4 +35,5 @@ void __init driver_init(void)
3435
cpu_dev_init();
3536
memory_dev_init();
3637
container_dev_init();
38+
of_core_init();
3739
}

drivers/of/base.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ int __of_attach_node_sysfs(struct device_node *np)
189189
return 0;
190190
}
191191

192-
static int __init of_init(void)
192+
void __init of_core_init(void)
193193
{
194194
struct device_node *np;
195195

@@ -198,7 +198,8 @@ static int __init of_init(void)
198198
of_kset = kset_create_and_add("devicetree", NULL, firmware_kobj);
199199
if (!of_kset) {
200200
mutex_unlock(&of_mutex);
201-
return -ENOMEM;
201+
pr_err("devicetree: failed to register existing nodes\n");
202+
return;
202203
}
203204
for_each_of_allnodes(np)
204205
__of_attach_node_sysfs(np);
@@ -207,10 +208,7 @@ static int __init of_init(void)
207208
/* Symlink in /proc as required by userspace ABI */
208209
if (of_root)
209210
proc_symlink("device-tree", NULL, "/sys/firmware/devicetree/base");
210-
211-
return 0;
212211
}
213-
core_initcall(of_init);
214212

215213
static struct property *__of_find_property(const struct device_node *np,
216214
const char *name, int *lenp)

include/linux/of.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,8 @@ extern struct device_node *of_stdout;
121121
extern raw_spinlock_t devtree_lock;
122122

123123
#ifdef CONFIG_OF
124+
void of_core_init(void);
125+
124126
static inline bool is_of_node(struct fwnode_handle *fwnode)
125127
{
126128
return fwnode && fwnode->type == FWNODE_OF;
@@ -376,6 +378,10 @@ bool of_console_check(struct device_node *dn, char *name, int index);
376378

377379
#else /* CONFIG_OF */
378380

381+
static inline void of_core_init(void)
382+
{
383+
}
384+
379385
static inline bool is_of_node(struct fwnode_handle *fwnode)
380386
{
381387
return false;

0 commit comments

Comments
 (0)