Skip to content

Commit 380032c

Browse files
author
Sarah Sharp
committed
xhci: STFU: Remove function tracing.
Remove unnecessary debugging from the xHCI driver. We don't need to know what function we're calling or returning from. Now I know how to use markup-oops.pl to de-mystify stack dumps of crashes. Signed-off-by: Sarah Sharp <[email protected]>
1 parent fe6c6c1 commit 380032c

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

drivers/usb/host/xhci-ring.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2182,7 +2182,6 @@ static int xhci_handle_event(struct xhci_hcd *xhci)
21822182
int update_ptrs = 1;
21832183
int ret;
21842184

2185-
xhci_dbg(xhci, "In %s\n", __func__);
21862185
if (!xhci->event_ring || !xhci->event_ring->dequeue) {
21872186
xhci->error_bitmask |= 1 << 1;
21882187
return 0;
@@ -2195,7 +2194,6 @@ static int xhci_handle_event(struct xhci_hcd *xhci)
21952194
xhci->error_bitmask |= 1 << 2;
21962195
return 0;
21972196
}
2198-
xhci_dbg(xhci, "%s - OS owns TRB\n", __func__);
21992197

22002198
/*
22012199
* Barrier between reading the TRB_CYCLE (valid) flag above and any
@@ -2205,20 +2203,14 @@ static int xhci_handle_event(struct xhci_hcd *xhci)
22052203
/* FIXME: Handle more event types. */
22062204
switch ((le32_to_cpu(event->event_cmd.flags) & TRB_TYPE_BITMASK)) {
22072205
case TRB_TYPE(TRB_COMPLETION):
2208-
xhci_dbg(xhci, "%s - calling handle_cmd_completion\n", __func__);
22092206
handle_cmd_completion(xhci, &event->event_cmd);
2210-
xhci_dbg(xhci, "%s - returned from handle_cmd_completion\n", __func__);
22112207
break;
22122208
case TRB_TYPE(TRB_PORT_STATUS):
2213-
xhci_dbg(xhci, "%s - calling handle_port_status\n", __func__);
22142209
handle_port_status(xhci, event);
2215-
xhci_dbg(xhci, "%s - returned from handle_port_status\n", __func__);
22162210
update_ptrs = 0;
22172211
break;
22182212
case TRB_TYPE(TRB_TRANSFER):
2219-
xhci_dbg(xhci, "%s - calling handle_tx_event\n", __func__);
22202213
ret = handle_tx_event(xhci, &event->trans_event);
2221-
xhci_dbg(xhci, "%s - returned from handle_tx_event\n", __func__);
22222214
if (ret < 0)
22232215
xhci->error_bitmask |= 1 << 9;
22242216
else

0 commit comments

Comments
 (0)