Skip to content

Commit 38674a4

Browse files
committed
Merge branch 'bcmgenet_systemport_stats'
Florian Fainelli says: ==================== net: bcmgenet and systemport statistics fixes This two patches fix a similar problem in the GENET and SYSTEMPORT drivers for software maintained statistics used to track DMA mapping and SKB re-allocation failures. ==================== Signed-off-by: David S. Miller <[email protected]>
2 parents 765dd3b + 55ff4ea commit 38674a4

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

drivers/net/ethernet/broadcom/bcmsysport.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -274,9 +274,9 @@ static const struct bcm_sysport_stats bcm_sysport_gstrings_stats[] = {
274274
/* RBUF misc statistics */
275275
STAT_RBUF("rbuf_ovflow_cnt", mib.rbuf_ovflow_cnt, RBUF_OVFL_DISC_CNTR),
276276
STAT_RBUF("rbuf_err_cnt", mib.rbuf_err_cnt, RBUF_ERR_PKT_CNTR),
277-
STAT_MIB_RX("alloc_rx_buff_failed", mib.alloc_rx_buff_failed),
278-
STAT_MIB_RX("rx_dma_failed", mib.rx_dma_failed),
279-
STAT_MIB_TX("tx_dma_failed", mib.tx_dma_failed),
277+
STAT_MIB_SOFT("alloc_rx_buff_failed", mib.alloc_rx_buff_failed),
278+
STAT_MIB_SOFT("rx_dma_failed", mib.rx_dma_failed),
279+
STAT_MIB_SOFT("tx_dma_failed", mib.tx_dma_failed),
280280
};
281281

282282
#define BCM_SYSPORT_STATS_LEN ARRAY_SIZE(bcm_sysport_gstrings_stats)
@@ -345,6 +345,7 @@ static void bcm_sysport_update_mib_counters(struct bcm_sysport_priv *priv)
345345
s = &bcm_sysport_gstrings_stats[i];
346346
switch (s->type) {
347347
case BCM_SYSPORT_STAT_NETDEV:
348+
case BCM_SYSPORT_STAT_SOFT:
348349
continue;
349350
case BCM_SYSPORT_STAT_MIB_RX:
350351
case BCM_SYSPORT_STAT_MIB_TX:

drivers/net/ethernet/broadcom/bcmsysport.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -570,6 +570,7 @@ enum bcm_sysport_stat_type {
570570
BCM_SYSPORT_STAT_RUNT,
571571
BCM_SYSPORT_STAT_RXCHK,
572572
BCM_SYSPORT_STAT_RBUF,
573+
BCM_SYSPORT_STAT_SOFT,
573574
};
574575

575576
/* Macros to help define ethtool statistics */
@@ -590,6 +591,7 @@ enum bcm_sysport_stat_type {
590591
#define STAT_MIB_RX(str, m) STAT_MIB(str, m, BCM_SYSPORT_STAT_MIB_RX)
591592
#define STAT_MIB_TX(str, m) STAT_MIB(str, m, BCM_SYSPORT_STAT_MIB_TX)
592593
#define STAT_RUNT(str, m) STAT_MIB(str, m, BCM_SYSPORT_STAT_RUNT)
594+
#define STAT_MIB_SOFT(str, m) STAT_MIB(str, m, BCM_SYSPORT_STAT_SOFT)
593595

594596
#define STAT_RXCHK(str, m, ofs) { \
595597
.stat_string = str, \

drivers/net/ethernet/broadcom/genet/bcmgenet.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -487,6 +487,7 @@ enum bcmgenet_stat_type {
487487
BCMGENET_STAT_MIB_TX,
488488
BCMGENET_STAT_RUNT,
489489
BCMGENET_STAT_MISC,
490+
BCMGENET_STAT_SOFT,
490491
};
491492

492493
struct bcmgenet_stats {
@@ -515,6 +516,7 @@ struct bcmgenet_stats {
515516
#define STAT_GENET_MIB_RX(str, m) STAT_GENET_MIB(str, m, BCMGENET_STAT_MIB_RX)
516517
#define STAT_GENET_MIB_TX(str, m) STAT_GENET_MIB(str, m, BCMGENET_STAT_MIB_TX)
517518
#define STAT_GENET_RUNT(str, m) STAT_GENET_MIB(str, m, BCMGENET_STAT_RUNT)
519+
#define STAT_GENET_SOFT_MIB(str, m) STAT_GENET_MIB(str, m, BCMGENET_STAT_SOFT)
518520

519521
#define STAT_GENET_MISC(str, m, offset) { \
520522
.stat_string = str, \
@@ -614,9 +616,9 @@ static const struct bcmgenet_stats bcmgenet_gstrings_stats[] = {
614616
UMAC_RBUF_OVFL_CNT),
615617
STAT_GENET_MISC("rbuf_err_cnt", mib.rbuf_err_cnt, UMAC_RBUF_ERR_CNT),
616618
STAT_GENET_MISC("mdf_err_cnt", mib.mdf_err_cnt, UMAC_MDF_ERR_CNT),
617-
STAT_GENET_MIB_RX("alloc_rx_buff_failed", mib.alloc_rx_buff_failed),
618-
STAT_GENET_MIB_RX("rx_dma_failed", mib.rx_dma_failed),
619-
STAT_GENET_MIB_TX("tx_dma_failed", mib.tx_dma_failed),
619+
STAT_GENET_SOFT_MIB("alloc_rx_buff_failed", mib.alloc_rx_buff_failed),
620+
STAT_GENET_SOFT_MIB("rx_dma_failed", mib.rx_dma_failed),
621+
STAT_GENET_SOFT_MIB("tx_dma_failed", mib.tx_dma_failed),
620622
};
621623

622624
#define BCMGENET_STATS_LEN ARRAY_SIZE(bcmgenet_gstrings_stats)
@@ -668,6 +670,7 @@ static void bcmgenet_update_mib_counters(struct bcmgenet_priv *priv)
668670
s = &bcmgenet_gstrings_stats[i];
669671
switch (s->type) {
670672
case BCMGENET_STAT_NETDEV:
673+
case BCMGENET_STAT_SOFT:
671674
continue;
672675
case BCMGENET_STAT_MIB_RX:
673676
case BCMGENET_STAT_MIB_TX:

0 commit comments

Comments
 (0)