Skip to content

Commit 38a36ef

Browse files
dtatuleaSaeed Mahameed
authored andcommitted
net/mlx5e: RX, Rename xdp_xmit_bitmap to a more generic name
The xdp_xmit_bitmap currently serves only one purpose: to avoid releasing pages that are still in use due to XDP TX. A following patch will use this bitmap in a slightly different context but for the same purpose. So rename the bitmap to a more generic name that reflects the purpose not the context. Signed-off-by: Dragos Tatulea <[email protected]> Reviewed-by: Tariq Toukan <[email protected]> Signed-off-by: Saeed Mahameed <[email protected]>
1 parent 6f57428 commit 38a36ef

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

drivers/net/ethernet/mellanox/mlx5/core/en.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -622,7 +622,7 @@ union mlx5e_alloc_units {
622622

623623
struct mlx5e_mpw_info {
624624
u16 consumed_strides;
625-
DECLARE_BITMAP(xdp_xmit_bitmap, MLX5_MPWRQ_MAX_PAGES_PER_WQE);
625+
DECLARE_BITMAP(skip_release_bitmap, MLX5_MPWRQ_MAX_PAGES_PER_WQE);
626626
union mlx5e_alloc_units alloc_units;
627627
};
628628

drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ int mlx5e_xsk_alloc_rx_mpwqe(struct mlx5e_rq *rq, u16 ix)
120120
}
121121
}
122122

123-
bitmap_zero(wi->xdp_xmit_bitmap, rq->mpwqe.pages_per_wqe);
123+
bitmap_zero(wi->skip_release_bitmap, rq->mpwqe.pages_per_wqe);
124124
wi->consumed_strides = 0;
125125

126126
umr_wqe->ctrl.opmod_idx_opcode =
@@ -289,7 +289,7 @@ struct sk_buff *mlx5e_xsk_skb_from_cqe_mpwrq_linear(struct mlx5e_rq *rq,
289289
prog = rcu_dereference(rq->xdp_prog);
290290
if (likely(prog && mlx5e_xdp_handle(rq, prog, mxbuf))) {
291291
if (likely(__test_and_clear_bit(MLX5E_RQ_FLAG_XDP_XMIT, rq->flags)))
292-
__set_bit(page_idx, wi->xdp_xmit_bitmap); /* non-atomic */
292+
__set_bit(page_idx, wi->skip_release_bitmap); /* non-atomic */
293293
return NULL; /* page/packet was consumed by XDP */
294294
}
295295

drivers/net/ethernet/mellanox/mlx5/core/en_rx.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -439,10 +439,10 @@ mlx5e_free_rx_mpwqe(struct mlx5e_rq *rq, struct mlx5e_mpw_info *wi, bool recycle
439439
int i;
440440

441441
/* A common case for AF_XDP. */
442-
if (bitmap_full(wi->xdp_xmit_bitmap, rq->mpwqe.pages_per_wqe))
442+
if (bitmap_full(wi->skip_release_bitmap, rq->mpwqe.pages_per_wqe))
443443
return;
444444

445-
no_xdp_xmit = bitmap_empty(wi->xdp_xmit_bitmap, rq->mpwqe.pages_per_wqe);
445+
no_xdp_xmit = bitmap_empty(wi->skip_release_bitmap, rq->mpwqe.pages_per_wqe);
446446

447447
if (rq->xsk_pool) {
448448
struct xdp_buff **xsk_buffs = wi->alloc_units.xsk_buffs;
@@ -452,11 +452,11 @@ mlx5e_free_rx_mpwqe(struct mlx5e_rq *rq, struct mlx5e_mpw_info *wi, bool recycle
452452
* the page to the userspace when the interface goes down.
453453
*/
454454
for (i = 0; i < rq->mpwqe.pages_per_wqe; i++)
455-
if (no_xdp_xmit || !test_bit(i, wi->xdp_xmit_bitmap))
455+
if (no_xdp_xmit || !test_bit(i, wi->skip_release_bitmap))
456456
xsk_buff_free(xsk_buffs[i]);
457457
} else {
458458
for (i = 0; i < rq->mpwqe.pages_per_wqe; i++) {
459-
if (no_xdp_xmit || !test_bit(i, wi->xdp_xmit_bitmap)) {
459+
if (no_xdp_xmit || !test_bit(i, wi->skip_release_bitmap)) {
460460
struct mlx5e_frag_page *frag_page;
461461

462462
frag_page = &wi->alloc_units.frag_pages[i];
@@ -687,7 +687,7 @@ static int mlx5e_alloc_rx_mpwqe(struct mlx5e_rq *rq, u16 ix)
687687
sizeof(*umr_wqe->inline_mtts) * pad);
688688
}
689689

690-
bitmap_zero(wi->xdp_xmit_bitmap, rq->mpwqe.pages_per_wqe);
690+
bitmap_zero(wi->skip_release_bitmap, rq->mpwqe.pages_per_wqe);
691691
wi->consumed_strides = 0;
692692

693693
umr_wqe->ctrl.opmod_idx_opcode =
@@ -1970,7 +1970,7 @@ mlx5e_skb_from_cqe_mpwrq_linear(struct mlx5e_rq *rq, struct mlx5e_mpw_info *wi,
19701970
mlx5e_fill_mxbuf(rq, cqe, va, rx_headroom, cqe_bcnt, &mxbuf);
19711971
if (mlx5e_xdp_handle(rq, prog, &mxbuf)) {
19721972
if (__test_and_clear_bit(MLX5E_RQ_FLAG_XDP_XMIT, rq->flags))
1973-
__set_bit(page_idx, wi->xdp_xmit_bitmap); /* non-atomic */
1973+
__set_bit(page_idx, wi->skip_release_bitmap); /* non-atomic */
19741974
return NULL; /* page/packet was consumed by XDP */
19751975
}
19761976

0 commit comments

Comments
 (0)