Skip to content

Commit 38c0a74

Browse files
committed
MIPS: Fix off-by-one in pci_resource_to_user()
The MIPS implementation of pci_resource_to_user() introduced in v3.12 by commit 4c2924b ("MIPS: PCI: Use pci_resource_to_user to map pci memory space properly") incorrectly sets *end to the address of the byte after the resource, rather than the last byte of the resource. This results in userland seeing resources as a byte larger than they actually are, for example a 32 byte BAR will be reported by a tool such as lspci as being 33 bytes in size: Region 2: I/O ports at 1000 [disabled] [size=33] Correct this by subtracting one from the calculated end address, reporting the correct address to userland. Signed-off-by: Paul Burton <[email protected]> Reported-by: Rui Wang <[email protected]> Fixes: 4c2924b ("MIPS: PCI: Use pci_resource_to_user to map pci memory space properly") Cc: James Hogan <[email protected]> Cc: Ralf Baechle <[email protected]> Cc: Wolfgang Grandegger <[email protected]> Cc: [email protected] Cc: [email protected] # v3.12+ Patchwork: https://patchwork.linux-mips.org/patch/19829/
1 parent 9d3cce1 commit 38c0a74

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/mips/pci/pci.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,5 +54,5 @@ void pci_resource_to_user(const struct pci_dev *dev, int bar,
5454
phys_addr_t size = resource_size(rsrc);
5555

5656
*start = fixup_bigphys_addr(rsrc->start, size);
57-
*end = rsrc->start + size;
57+
*end = rsrc->start + size - 1;
5858
}

0 commit comments

Comments
 (0)