Skip to content

Commit 3ab4ac8

Browse files
Lai Jiangshanbonzini
authored andcommitted
KVM: VMX: Update msr value after kvm_set_user_return_msr() succeeds
Aoid earlier modification. Signed-off-by: Lai Jiangshan <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
1 parent 6ab8a40 commit 3ab4ac8

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

arch/x86/kvm/vmx/vmx.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -602,15 +602,13 @@ static int vmx_set_guest_uret_msr(struct vcpu_vmx *vmx,
602602
unsigned int slot = msr - vmx->guest_uret_msrs;
603603
int ret = 0;
604604

605-
u64 old_msr_data = msr->data;
606-
msr->data = data;
607605
if (msr->load_into_hardware) {
608606
preempt_disable();
609-
ret = kvm_set_user_return_msr(slot, msr->data, msr->mask);
607+
ret = kvm_set_user_return_msr(slot, data, msr->mask);
610608
preempt_enable();
611-
if (ret)
612-
msr->data = old_msr_data;
613609
}
610+
if (!ret)
611+
msr->data = data;
614612
return ret;
615613
}
616614

0 commit comments

Comments
 (0)