Skip to content

Commit 3b2b7d9

Browse files
Michael Chandavem330
authored andcommitted
bnxt_en: Check for NULL rx or tx ring.
Each bnxt_napi structure may no longer be having both an rx ring and a tx ring. Check for a valid ring before using it. Signed-off-by: Michael Chan <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent b6ab4b0 commit 3b2b7d9

File tree

1 file changed

+22
-5
lines changed
  • drivers/net/ethernet/broadcom/bnxt

1 file changed

+22
-5
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt.c

Lines changed: 22 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1867,6 +1867,9 @@ static void bnxt_init_ring_struct(struct bnxt *bp)
18671867
ring->vmem_size = 0;
18681868

18691869
rxr = bnapi->rx_ring;
1870+
if (!rxr)
1871+
goto skip_rx;
1872+
18701873
ring = &rxr->rx_ring_struct;
18711874
ring->nr_pages = bp->rx_nr_pages;
18721875
ring->page_size = HW_RXBD_RING_SIZE;
@@ -1883,7 +1886,11 @@ static void bnxt_init_ring_struct(struct bnxt *bp)
18831886
ring->vmem_size = SW_RXBD_AGG_RING_SIZE * bp->rx_agg_nr_pages;
18841887
ring->vmem = (void **)&rxr->rx_agg_ring;
18851888

1889+
skip_rx:
18861890
txr = bnapi->tx_ring;
1891+
if (!txr)
1892+
continue;
1893+
18871894
ring = &txr->tx_ring_struct;
18881895
ring->nr_pages = bp->tx_nr_pages;
18891896
ring->page_size = HW_RXBD_RING_SIZE;
@@ -2400,13 +2407,17 @@ static void bnxt_clear_ring_indices(struct bnxt *bp)
24002407
cpr->cp_raw_cons = 0;
24012408

24022409
txr = bnapi->tx_ring;
2403-
txr->tx_prod = 0;
2404-
txr->tx_cons = 0;
2410+
if (txr) {
2411+
txr->tx_prod = 0;
2412+
txr->tx_cons = 0;
2413+
}
24052414

24062415
rxr = bnapi->rx_ring;
2407-
rxr->rx_prod = 0;
2408-
rxr->rx_agg_prod = 0;
2409-
rxr->rx_sw_agg_prod = 0;
2416+
if (rxr) {
2417+
rxr->rx_prod = 0;
2418+
rxr->rx_agg_prod = 0;
2419+
rxr->rx_sw_agg_prod = 0;
2420+
}
24102421
}
24112422
}
24122423

@@ -4999,6 +5010,9 @@ static void bnxt_dump_tx_sw_state(struct bnxt_napi *bnapi)
49995010
struct bnxt_tx_ring_info *txr = bnapi->tx_ring;
50005011
int i = bnapi->index;
50015012

5013+
if (!txr)
5014+
return;
5015+
50025016
netdev_info(bnapi->bp->dev, "[%d]: tx{fw_ring: %d prod: %x cons: %x}\n",
50035017
i, txr->tx_ring_struct.fw_ring_id, txr->tx_prod,
50045018
txr->tx_cons);
@@ -5009,6 +5023,9 @@ static void bnxt_dump_rx_sw_state(struct bnxt_napi *bnapi)
50095023
struct bnxt_rx_ring_info *rxr = bnapi->rx_ring;
50105024
int i = bnapi->index;
50115025

5026+
if (!rxr)
5027+
return;
5028+
50125029
netdev_info(bnapi->bp->dev, "[%d]: rx{fw_ring: %d prod: %x} rx_agg{fw_ring: %d agg_prod: %x sw_agg_prod: %x}\n",
50135030
i, rxr->rx_ring_struct.fw_ring_id, rxr->rx_prod,
50145031
rxr->rx_agg_ring_struct.fw_ring_id, rxr->rx_agg_prod,

0 commit comments

Comments
 (0)