lan78xx: remove redundant initialization of pointer 'phydev'

Colin Ian King · davem330 · commit 3b51cc75eba2 · 2018-02-01T14:54:28.000-05:00
Pointer phydev is initialized and this value is never read, phydev
is immediately updated to a new value, hence this initialization
is redundant and can be removed

Cleans up clang warning:
drivers/net/usb/lan78xx.c:2009:21: warning: Value stored to 'phydev'
during its initialization is never read

Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
@@ -2006,7 +2006,7 @@ static int lan78xx_phy_init(struct lan78xx_net *dev)
 {
 	int ret;
 	u32 mii_adv;
-	struct phy_device *phydev = dev->net->phydev;
+	struct phy_device *phydev;
 
 	phydev = phy_find_first(dev->mdiobus);
 	if (!phydev) {

Original file line number	Diff line number	Diff line change
`@@ -2006,7 +2006,7 @@ static int lan78xx_phy_init(struct lan78xx_net *dev)`
`2006`	`2006`	`{`
`2007`	`2007`	`int ret;`
`2008`	`2008`	`u32 mii_adv;`
`2009`		`- struct phy_device *phydev = dev->net->phydev;`
	`2009`	`+ struct phy_device *phydev;`
`2010`	`2010`
`2011`	`2011`	`phydev = phy_find_first(dev->mdiobus);`
`2012`	`2012`	`if (!phydev) {`