Skip to content

Commit 3b5c6b8

Browse files
committed
Merge branch 'sched-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
* 'sched-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip: cpusets, hotplug, scheduler: fix scheduler domain breakage
2 parents 9df2fe9 + 3e84050 commit 3b5c6b8

File tree

1 file changed

+18
-6
lines changed

1 file changed

+18
-6
lines changed

kernel/cpuset.c

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1882,7 +1882,7 @@ static void scan_for_empty_cpusets(const struct cpuset *root)
18821882
* in order to minimize text size.
18831883
*/
18841884

1885-
static void common_cpu_mem_hotplug_unplug(void)
1885+
static void common_cpu_mem_hotplug_unplug(int rebuild_sd)
18861886
{
18871887
cgroup_lock();
18881888

@@ -1894,7 +1894,8 @@ static void common_cpu_mem_hotplug_unplug(void)
18941894
* Scheduler destroys domains on hotplug events.
18951895
* Rebuild them based on the current settings.
18961896
*/
1897-
rebuild_sched_domains();
1897+
if (rebuild_sd)
1898+
rebuild_sched_domains();
18981899

18991900
cgroup_unlock();
19001901
}
@@ -1912,11 +1913,22 @@ static void common_cpu_mem_hotplug_unplug(void)
19121913
static int cpuset_handle_cpuhp(struct notifier_block *unused_nb,
19131914
unsigned long phase, void *unused_cpu)
19141915
{
1915-
if (phase == CPU_DYING || phase == CPU_DYING_FROZEN)
1916+
switch (phase) {
1917+
case CPU_UP_CANCELED:
1918+
case CPU_UP_CANCELED_FROZEN:
1919+
case CPU_DOWN_FAILED:
1920+
case CPU_DOWN_FAILED_FROZEN:
1921+
case CPU_ONLINE:
1922+
case CPU_ONLINE_FROZEN:
1923+
case CPU_DEAD:
1924+
case CPU_DEAD_FROZEN:
1925+
common_cpu_mem_hotplug_unplug(1);
1926+
break;
1927+
default:
19161928
return NOTIFY_DONE;
1929+
}
19171930

1918-
common_cpu_mem_hotplug_unplug();
1919-
return 0;
1931+
return NOTIFY_OK;
19201932
}
19211933

19221934
#ifdef CONFIG_MEMORY_HOTPLUG
@@ -1929,7 +1941,7 @@ static int cpuset_handle_cpuhp(struct notifier_block *unused_nb,
19291941

19301942
void cpuset_track_online_nodes(void)
19311943
{
1932-
common_cpu_mem_hotplug_unplug();
1944+
common_cpu_mem_hotplug_unplug(0);
19331945
}
19341946
#endif
19351947

0 commit comments

Comments
 (0)