Skip to content

Commit 3b7884f

Browse files
fengyuleidian0615Jeff Kirsher
authored andcommitted
ixgbe: Don't report flow director filter's status
For two reasons I want to disable this: 1. Not any part actually check the report status(Alexander Duyck) 2. To report hash value of a packet to stack, RSS -> 32bits hash value Perfect match fdir filter -> 13bits hash value Hashed-based fdir filter -> 31bits hash value fdir filter might hash on masked tuples for IP address, so it's still not desirable for usage. So for now, just stick to RSS 32bits hash value. Signed-off-by: Fan Du <[email protected]> Suggested-by: Alexander Duyck <[email protected]> Tested-by: Phil Schmitt <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]>
1 parent 1e1429d commit 3b7884f

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1394,14 +1394,12 @@ s32 ixgbe_init_fdir_perfect_82599(struct ixgbe_hw *hw, u32 fdirctrl)
13941394
/*
13951395
* Continue setup of fdirctrl register bits:
13961396
* Turn perfect match filtering on
1397-
* Report hash in RSS field of Rx wb descriptor
13981397
* Initialize the drop queue
13991398
* Move the flexible bytes to use the ethertype - shift 6 words
14001399
* Set the maximum length per hash bucket to 0xA filters
14011400
* Send interrupt when 64 (0x4 * 16) filters are left
14021401
*/
14031402
fdirctrl |= IXGBE_FDIRCTRL_PERFECT_MATCH |
1404-
IXGBE_FDIRCTRL_REPORT_STATUS |
14051403
(IXGBE_FDIR_DROP_QUEUE << IXGBE_FDIRCTRL_DROP_Q_SHIFT) |
14061404
(0x6 << IXGBE_FDIRCTRL_FLEX_SHIFT) |
14071405
(0xA << IXGBE_FDIRCTRL_MAX_LENGTH_SHIFT) |

0 commit comments

Comments
 (0)