Skip to content

Commit 3c521f2

Browse files
committed
ipv4: Don't report neigh uptodate state in rtcache procfs.
Soon routes will not have a cached neigh attached, nor will we be able to necessarily go directly to a neigh from an arbitrary route. Signed-off-by: David S. Miller <[email protected]>
1 parent a263b30 commit 3c521f2

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

net/ipv4/route.c

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -418,13 +418,7 @@ static int rt_cache_seq_show(struct seq_file *seq, void *v)
418418
"HHUptod\tSpecDst");
419419
else {
420420
struct rtable *r = v;
421-
struct neighbour *n;
422-
int len, HHUptod;
423-
424-
rcu_read_lock();
425-
n = dst_get_neighbour_noref(&r->dst);
426-
HHUptod = (n && (n->nud_state & NUD_CONNECTED)) ? 1 : 0;
427-
rcu_read_unlock();
421+
int len;
428422

429423
seq_printf(seq, "%s\t%08X\t%08X\t%8X\t%d\t%u\t%d\t"
430424
"%08X\t%d\t%u\t%u\t%02X\t%d\t%1d\t%08X%n",
@@ -438,9 +432,7 @@ static int rt_cache_seq_show(struct seq_file *seq, void *v)
438432
(int)((dst_metric(&r->dst, RTAX_RTT) >> 3) +
439433
dst_metric(&r->dst, RTAX_RTTVAR)),
440434
r->rt_key_tos,
441-
-1,
442-
HHUptod,
443-
0, &len);
435+
-1, 0, 0, &len);
444436

445437
seq_printf(seq, "%*s\n", 127 - len, "");
446438
}

0 commit comments

Comments
 (0)