Skip to content

Commit 3c8a23c

Browse files
linuswdtor
authored andcommitted
Input: gpio_tilt - delete driver
This driver was merged in 2011 as a tool for detecting the orientation of a screen. The device driver assumes board file setup using the platform data from <linux/input/gpio_tilt.h>. But no boards in the kernel tree defines this platform data. As I am faced with refactoring drivers to use GPIO descriptors and pass decriptor tables from boards, or use the device tree device drivers like these creates a serious problem: I cannot fix them and cannot test them, not even compile-test them with a system actually using it (no in-tree boardfile). I suggest to delete this driver and rewrite it using device tree if it is still in use on actively maintained systems. I can also offer to rewrite it out of the blue using device tree if someone promise to test it and help me iterate it. Signed-off-by: Linus Walleij <[email protected]> Acked-by: Heiko Stuebner <[email protected]> Patchwork-Id: 10133609 Signed-off-by: Dmitry Torokhov <[email protected]>
1 parent b3495ce commit 3c8a23c

File tree

6 files changed

+0
-407
lines changed

6 files changed

+0
-407
lines changed

Documentation/gpio/drivers-on-gpio.txt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,6 @@ hardware descriptions such as device tree or ACPI:
2828
- gpio-beeper: drivers/input/misc/gpio-beeper.c is used to provide a beep from
2929
an external speaker connected to a GPIO line.
3030

31-
- gpio-tilt-polled: drivers/input/misc/gpio_tilt_polled.c provides tilt
32-
detection switches using GPIO, which is useful for your homebrewn pinball
33-
machine if for nothing else. It can detect different tilt angles of the
34-
monitored object.
35-
3631
- extcon-gpio: drivers/extcon/extcon-gpio.c is used when you need to read an
3732
external connector status, such as a headset line for an audio driver or an
3833
HDMI connector. It will provide a better userspace sysfs interface than GPIO.

Documentation/input/devices/gpio-tilt.rst

Lines changed: 0 additions & 103 deletions
This file was deleted.

drivers/input/misc/Kconfig

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -268,20 +268,6 @@ config INPUT_GPIO_BEEPER
268268
To compile this driver as a module, choose M here: the
269269
module will be called gpio-beeper.
270270

271-
config INPUT_GPIO_TILT_POLLED
272-
tristate "Polled GPIO tilt switch"
273-
depends on GPIOLIB || COMPILE_TEST
274-
select INPUT_POLLDEV
275-
help
276-
This driver implements support for tilt switches connected
277-
to GPIO pins that are not capable of generating interrupts.
278-
279-
The list of gpios to use and the mapping of their states
280-
to specific angles is done via platform data.
281-
282-
To compile this driver as a module, choose M here: the
283-
module will be called gpio_tilt_polled.
284-
285271
config INPUT_GPIO_DECODER
286272
tristate "Polled GPIO Decoder Input driver"
287273
depends on GPIOLIB || COMPILE_TEST

drivers/input/misc/Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ obj-$(CONFIG_INPUT_DRV2665_HAPTICS) += drv2665.o
3636
obj-$(CONFIG_INPUT_DRV2667_HAPTICS) += drv2667.o
3737
obj-$(CONFIG_INPUT_GP2A) += gp2ap002a00f.o
3838
obj-$(CONFIG_INPUT_GPIO_BEEPER) += gpio-beeper.o
39-
obj-$(CONFIG_INPUT_GPIO_TILT_POLLED) += gpio_tilt_polled.o
4039
obj-$(CONFIG_INPUT_GPIO_DECODER) += gpio_decoder.o
4140
obj-$(CONFIG_INPUT_HISI_POWERKEY) += hisi_powerkey.o
4241
obj-$(CONFIG_HP_SDC_RTC) += hp_sdc_rtc.o

drivers/input/misc/gpio_tilt_polled.c

Lines changed: 0 additions & 210 deletions
This file was deleted.

0 commit comments

Comments
 (0)