Skip to content

Commit 3c8f771

Browse files
rjarzmikbroonie
authored andcommitted
ASoC: fix broken pxa SoC support
The previous fix of pxa library support, which was introduced to fix the library dependency, broke the previous SoC behavior, where a machine code binding pxa2xx-ac97 with a coded relied on : - sound/soc/pxa/pxa2xx-ac97.c - sound/soc/codecs/XXX.c For example, the mioa701_wm9713.c machine code is currently broken. The "select ARM" statement wrongly selects the soc/arm/pxa2xx-ac97 for compilation, as per an unfortunate fate SND_PXA2XX_AC97 is both declared in sound/arm/Kconfig and sound/soc/pxa/Kconfig. Fix this by ensuring that SND_PXA2XX_SOC correctly triggers the correct pxa2xx-ac97 compilation. Fixes: 846172d ("ASoC: fix SND_PXA2XX_LIB Kconfig warning") Signed-off-by: Robert Jarzmik <[email protected]> Signed-off-by: Mark Brown <[email protected]>
1 parent 6ff33f3 commit 3c8f771

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

sound/arm/Kconfig

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,14 @@ menuconfig SND_ARM
99
Drivers that are implemented on ASoC can be found in
1010
"ALSA for SoC audio support" section.
1111

12+
config SND_PXA2XX_LIB
13+
tristate
14+
select SND_AC97_CODEC if SND_PXA2XX_LIB_AC97
15+
select SND_DMAENGINE_PCM
16+
17+
config SND_PXA2XX_LIB_AC97
18+
bool
19+
1220
if SND_ARM
1321

1422
config SND_ARMAACI
@@ -21,13 +29,6 @@ config SND_PXA2XX_PCM
2129
tristate
2230
select SND_PCM
2331

24-
config SND_PXA2XX_LIB
25-
tristate
26-
select SND_AC97_CODEC if SND_PXA2XX_LIB_AC97
27-
28-
config SND_PXA2XX_LIB_AC97
29-
bool
30-
3132
config SND_PXA2XX_AC97
3233
tristate "AC97 driver for the Intel PXA2xx chip"
3334
depends on ARCH_PXA

sound/soc/pxa/Kconfig

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
config SND_PXA2XX_SOC
22
tristate "SoC Audio for the Intel PXA2xx chip"
33
depends on ARCH_PXA
4-
select SND_ARM
54
select SND_PXA2XX_LIB
65
help
76
Say Y or M if you want to add support for codecs attached to
@@ -25,7 +24,6 @@ config SND_PXA2XX_AC97
2524
config SND_PXA2XX_SOC_AC97
2625
tristate
2726
select AC97_BUS
28-
select SND_ARM
2927
select SND_PXA2XX_LIB_AC97
3028
select SND_SOC_AC97_BUS
3129

0 commit comments

Comments
 (0)