Skip to content

Commit 3cb30b7

Browse files
awilliambjorn-helgaas
authored andcommitted
PCI: Mark RTL8110SC INTx masking as broken
INTx masking does not work on this device. To see this, configure the network device UP on an active network, note that the interrupt count continues to increment for the device in /proc/interrupts. Use setpci to set the PCI_COMMAND_INTX_DISABLE bit in the PCI_COMMAND register. As expected, the interrupt count ceases to increment. However, reading the PCI_STATUS_INTERRUPT bit of the PCI_STATUS register does not indicate that interrupts are pending and clearing PCI_COMMAND_INTX_DISABLE in the PCI_COMMAND register does not allow the device to continue operation. This does not affect operation of the host r8169 driver, but it does prevent the device from being functional when assigned to a VM, such as with QEMU and VFIO. The guest driver successfully probes the device, but there is no traffic. Mark INTx masking as broken, allowing the more restrictive APIC masking to be used instead. Signed-off-by: Alex Williamson <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]>
1 parent 1a30fd0 commit 3cb30b7

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

drivers/pci/quirks.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2991,6 +2991,14 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_CHELSIO, 0x0030,
29912991
quirk_broken_intx_masking);
29922992
DECLARE_PCI_FIXUP_HEADER(0x1814, 0x0601, /* Ralink RT2800 802.11n PCI */
29932993
quirk_broken_intx_masking);
2994+
/*
2995+
* Realtek RTL8169 PCI Gigabit Ethernet Controller (rev 10)
2996+
* Subsystem: Realtek RTL8169/8110 Family PCI Gigabit Ethernet NIC
2997+
*
2998+
* RTL8110SC - Fails under PCI device assignment using DisINTx masking.
2999+
*/
3000+
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_REALTEK, 0x8169,
3001+
quirk_broken_intx_masking);
29943002

29953003
static void pci_do_fixups(struct pci_dev *dev, struct pci_fixup *f,
29963004
struct pci_fixup *end)

0 commit comments

Comments
 (0)