Bluetooth: kfree tmp rather than an alias to it

Colin Ian King · holtmann · commit 3dfe55d9cae7 · 2017-08-11T21:19:46.000+02:00
While the kfree of dhkey_a is of the same address of tmp, it
probably is clearer and more human readable if tmp is kfree'd
rather than dhkey_a.

Detected by CoverityScan, CID#1448650 ("Free of address-of expression")
Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: Marcel Holtmann &lt;marcel@holtmann.org&gt;
diff --git a/net/bluetooth/selftest.c b/net/bluetooth/selftest.c
@@ -164,7 +164,7 @@ static int __init test_ecdh_sample(const u8 priv_a[32], const u8 priv_b[32],
 		ret = -EINVAL;
 
 out:
-	kfree(dhkey_a);
+	kfree(tmp);
 	return ret;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ static int __init test_ecdh_sample(const u8 priv_a[32], const u8 priv_b[32],`
`164`	`164`	`ret = -EINVAL;`
`165`	`165`
`166`	`166`	`out:`
`167`		`- kfree(dhkey_a);`
	`167`	`+ kfree(tmp);`
`168`	`168`	`return ret;`
`169`	`169`	`}`
`170`	`170`