Skip to content

Commit 3e39da4

Browse files
dmertmananguy11
authored andcommitted
ice: Fix SRIOV LAG disable on non-compliant aggregate
If an attribute of an aggregate interface disqualifies it from supporting SRIOV, the driver will unwind the SRIOV support. Currently the driver is clearing the feature bit for all interfaces in the aggregate, but this is not allowing the other interfaces to unwind successfully on driver unload. Only clear the feature bit for the interface that is currently unwinding. Fixes: bf65da2 ("ice: enforce interface eligibility and add messaging for SRIOV LAG") Signed-off-by: Dave Ertman <[email protected]> Reviewed-by: Wojciech Drewek <[email protected]> Reviewed-by: Simon Horman <[email protected]> Tested-by: Sujai Buvaneswaran <[email protected]> Signed-off-by: Tony Nguyen <[email protected]>
1 parent c1ed833 commit 3e39da4

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

drivers/net/ethernet/intel/ice/ice_lag.c

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1555,18 +1555,12 @@ static void ice_lag_chk_disabled_bond(struct ice_lag *lag, void *ptr)
15551555
*/
15561556
static void ice_lag_disable_sriov_bond(struct ice_lag *lag)
15571557
{
1558-
struct ice_lag_netdev_list *entry;
15591558
struct ice_netdev_priv *np;
1560-
struct net_device *netdev;
15611559
struct ice_pf *pf;
15621560

1563-
list_for_each_entry(entry, lag->netdev_head, node) {
1564-
netdev = entry->netdev;
1565-
np = netdev_priv(netdev);
1566-
pf = np->vsi->back;
1567-
1568-
ice_clear_feature_support(pf, ICE_F_SRIOV_LAG);
1569-
}
1561+
np = netdev_priv(lag->netdev);
1562+
pf = np->vsi->back;
1563+
ice_clear_feature_support(pf, ICE_F_SRIOV_LAG);
15701564
}
15711565

15721566
/**

0 commit comments

Comments
 (0)