Skip to content

Commit 3e59081

Browse files
committed
Merge tag 'ieee802154-for-net-next-2025-01-03' of git://git.kernel.org/pub/scm/linux/kernel/git/wpan/wpan-next
Stefan Schmidt says: ==================== pull-request: ieee802154-next 2025-01-03 Leo Stone provided a documatation fix to improve the grammar. David Gilbert spotted a non-used fucntion we can safely remove. * tag 'ieee802154-for-net-next-2025-01-03' of git://git.kernel.org/pub/scm/linux/kernel/git/wpan/wpan-next: net: mac802154: Remove unused ieee802154_mlme_tx_one Documentation: ieee802154: fix grammar ==================== Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
2 parents 3569399 + bddfe23 commit 3e59081

File tree

3 files changed

+9
-23
lines changed

3 files changed

+9
-23
lines changed

Documentation/networking/ieee802154.rst

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,8 @@ exports a management (e.g. MLME) and data API.
7272
possibly with some kinds of acceleration like automatic CRC computation and
7373
comparison, automagic ACK handling, address matching, etc.
7474

75-
Those types of devices require different approach to be hooked into Linux kernel.
75+
Each type of device requires a different approach to be hooked into the Linux
76+
kernel.
7677

7778
HardMAC
7879
-------
@@ -81,10 +82,10 @@ See the header include/net/ieee802154_netdev.h. You have to implement Linux
8182
net_device, with .type = ARPHRD_IEEE802154. Data is exchanged with socket family
8283
code via plain sk_buffs. On skb reception skb->cb must contain additional
8384
info as described in the struct ieee802154_mac_cb. During packet transmission
84-
the skb->cb is used to provide additional data to device's header_ops->create
85-
function. Be aware that this data can be overridden later (when socket code
86-
submits skb to qdisc), so if you need something from that cb later, you should
87-
store info in the skb->data on your own.
85+
the skb->cb is used to provide additional data to the device's
86+
header_ops->create function. Be aware that this data can be overridden later
87+
(when socket code submits skb to qdisc), so if you need something from that cb
88+
later, you should store info in the skb->data on your own.
8889

8990
To hook the MLME interface you have to populate the ml_priv field of your
9091
net_device with a pointer to struct ieee802154_mlme_ops instance. The fields
@@ -94,8 +95,9 @@ All other fields are required.
9495
SoftMAC
9596
-------
9697

97-
The MAC is the middle layer in the IEEE 802.15.4 Linux stack. This moment it
98-
provides interface for drivers registration and management of slave interfaces.
98+
The MAC is the middle layer in the IEEE 802.15.4 Linux stack. At the moment, it
99+
provides an interface for driver registration and management of slave
100+
interfaces.
99101

100102
NOTE: Currently the only monitor device type is supported - it's IEEE 802.15.4
101103
stack interface for network sniffers (e.g. WireShark).

net/mac802154/ieee802154_i.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -194,9 +194,6 @@ int ieee802154_mlme_tx_locked(struct ieee802154_local *local,
194194
struct ieee802154_sub_if_data *sdata,
195195
struct sk_buff *skb);
196196
void ieee802154_mlme_op_post(struct ieee802154_local *local);
197-
int ieee802154_mlme_tx_one(struct ieee802154_local *local,
198-
struct ieee802154_sub_if_data *sdata,
199-
struct sk_buff *skb);
200197
int ieee802154_mlme_tx_one_locked(struct ieee802154_local *local,
201198
struct ieee802154_sub_if_data *sdata,
202199
struct sk_buff *skb);

net/mac802154/tx.c

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -178,19 +178,6 @@ void ieee802154_mlme_op_post(struct ieee802154_local *local)
178178
ieee802154_release_queue(local);
179179
}
180180

181-
int ieee802154_mlme_tx_one(struct ieee802154_local *local,
182-
struct ieee802154_sub_if_data *sdata,
183-
struct sk_buff *skb)
184-
{
185-
int ret;
186-
187-
ieee802154_mlme_op_pre(local);
188-
ret = ieee802154_mlme_tx(local, sdata, skb);
189-
ieee802154_mlme_op_post(local);
190-
191-
return ret;
192-
}
193-
194181
int ieee802154_mlme_tx_one_locked(struct ieee802154_local *local,
195182
struct ieee802154_sub_if_data *sdata,
196183
struct sk_buff *skb)

0 commit comments

Comments
 (0)